mirrors/versitygw
1
0
Fork 0
mirror of https://github.com/versity/versitygw.git synced 2026-08-20 06:06:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: store part checksums at destination path in UploadPartCopy

Browse Source 
In sidecar mode, the three StoreAttribute/storeChecksums calls after the
copy loop were using objPath (the source object path) instead of the
destination part's bucket and partPath. This caused checksums and the
internal part-crc64nvme to be written under the source object's sidecar
directory, making them unresolvable when CompleteMultipartUploadWithCopy
tried to retrieve them. All three stores now use *upi.Bucket and partPath,
consistent with the etag store directly below them.
This commit is contained in:
Ben McClelland
2026-02-28 10:24:15 -08:00
parent ca3c76b0f9
commit 7695be56b0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/posix/posix.go
+3 -3
View File
@@ -3036,7 +3036,7 @@ func (p *Posix) UploadPartCopy(ctx context.Context, upi *s3.UploadPartCopyInput)
checksums = s3response.Checksum{}
} else {
if hashRdr == nil {
err := p.storeChecksums(f.File(), objPath, "", checksums)
err := p.storeChecksums(f.File(), *upi.Bucket, partPath, checksums)
if err != nil {
return s3response.CopyPartResult{}, fmt.Errorf("store part checksum: %w", err)
}
@@ -3064,7 +3064,7 @@ func (p *Posix) UploadPartCopy(ctx context.Context, upi *s3.UploadPartCopyInput)
checksums.CRC64NVME = &sum
}
err := p.storeChecksums(f.File(), objPath, "", checksums)
err := p.storeChecksums(f.File(), *upi.Bucket, partPath, checksums)
if err != nil {
return s3response.CopyPartResult{}, fmt.Errorf("store part checksum: %w", err)
}
@@ -3073,7 +3073,7 @@ func (p *Posix) UploadPartCopy(ctx context.Context, upi *s3.UploadPartCopyInput)
if crc64nvmeRdr != nil {
// store the internal crc64nvme
internalCrc64NvmeSum := crc64nvmeRdr.Sum()
err := p.meta.StoreAttribute(f.File(), objPath, "", partCrc64nvme, []byte(internalCrc64NvmeSum))
err := p.meta.StoreAttribute(f.File(), *upi.Bucket, partPath, partCrc64nvme, []byte(internalCrc64NvmeSum))
if err != nil {
return s3response.CopyPartResult{}, fmt.Errorf("store part internal crc64nvme: %w", err)
}