mirrors/versitygw
1
0
Fork 0
mirror of https://github.com/versity/versitygw.git synced 2026-09-22 16:04:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: return BucketAlreadyExists for existing dirs without acl meta attr

Browse Source 
`CreateBucket` on an existing directory read the bucket acl meta attribute to decide between `BucketAlreadyOwnedByYou` and `BucketAlreadyExists`. For a directory that predates the gateway (or was created outside it) the attribute is missing, so the retrieve failed with `meta.ErrNoSuchKey` and the call returned a wrapped internal error instead of an S3 error. Treat a missing acl attribute as a bucket that exists and is not owned by the caller.
This commit is contained in:
niksis02
2026-09-09 18:57:18 +04:00
parent 7f0a793150
commit a58e125184
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/posix/posix.go
+6
View File
@@ -669,6 +669,12 @@ func (p *Posix) CreateBucket(ctx context.Context, input *s3.CreateBucketInput, a
err = os.Mkdir(bucket, p.newDirPerm)
if err != nil && os.IsExist(err) {
aclJSON, err := p.meta.RetrieveAttribute(nil, bucket, "", aclkey)
if errors.Is(err, meta.ErrNoSuchKey) {
// The directory already exists but has no gateway-managed acl
// attribute, e.g. a preexisting directory on a dataset the
// gateway was pointed at rather than one created via CreateBucket
return s3err.GetBucketErr(s3err.ErrBucketAlreadyExists, bucket)
}
if err != nil {
return fmt.Errorf("get bucket acl: %w", err)
}