mirrors/versitygw
1
0
Fork 0
mirror of https://github.com/versity/versitygw.git synced 2026-07-19 22:42:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent index-out-of-range panic in s3proxy GetBucketOwnershipControls

Browse Source 
Add nil and length checks before accessing
resp.OwnershipControls.Rules[0]. If the upstream S3 backend returns
a response with nil OwnershipControls or empty Rules, the server
panics with an index-out-of-range error. Return
OwnershipControlsNotFoundError instead, matching the behavior of
the posix and azure backends.

This bug was introduced in commit 7545e623 (2024-06-28) when bucket
ownership controls were first implemented for the s3proxy backend.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This commit is contained in:
Sebastien Tardif
2026-06-09 19:49:07 -07:00
parent 8ae0d36d80
commit cf4bc65570
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/s3proxy/s3.go
+3
View File
@@ -258,6 +258,9 @@ func (s *S3Proxy) GetBucketOwnershipControls(ctx context.Context, bucket string)
if err != nil {
return ownship, handleError(err)
}
if resp.OwnershipControls == nil || len(resp.OwnershipControls.Rules) == 0 {
return ownship, s3err.GetBucketErr(s3err.ErrOwnershipControlsNotFound, bucket)
}
return resp.OwnershipControls.Rules[0].ObjectOwnership, nil
}
func (s *S3Proxy) DeleteBucketOwnershipControls(ctx context.Context, bucket string) error {