mirrors/versitygw
1
0
Fork 0
mirror of https://github.com/versity/versitygw.git synced 2026-07-19 06:22:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2159 from versity/ben/webui-storageclass

Browse Source 
fix: expose x-amz-storage-class in CORS response headers
This commit is contained in:
Ben McClelland
2026-06-01 09:23:01 -07:00
committed by GitHub
parent ba51c0a850 0e165edfb1
commit da6aa1c843
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
s3api/controllers/cors_default_origin_test.go
+2 -2
View File
@@ -55,8 +55,8 @@ func TestApplyBucketCORS_FallbackOrigin_NoBucketCors_NoRequestOrigin(t *testing.
if got := resp.Header.Get("Access-Control-Allow-Origin"); got != origin {
t.Fatalf("expected Access-Control-Allow-Origin to be set to fallback, got %q", got)
}
if got := resp.Header.Get("Access-Control-Expose-Headers"); got != "ETag" {
t.Fatalf("expected Access-Control-Expose-Headers to include ETag, got %q", got)
if got := resp.Header.Get("Access-Control-Expose-Headers"); got != "ETag, x-amz-storage-class" {
t.Fatalf("expected Access-Control-Expose-Headers to include ETag and x-amz-storage-class, got %q", got)
}
}
s3api/middlewares/apply-default-cors.go
+1 -1
View File
@@ -22,7 +22,7 @@ import (
func ensureExposeETag(ctx *fiber.Ctx) {
existing := strings.TrimSpace(string(ctx.Response().Header.Peek("Access-Control-Expose-Headers")))
defaults := []string{"ETag"}
defaults := []string{"ETag", "x-amz-storage-class"}
if existing == "" {
ctx.Response().Header.Add("Access-Control-Expose-Headers", strings.Join(defaults, ", "))
return
s3api/middlewares/apply-default-cors_test.go
+2 -2
View File
@@ -43,8 +43,8 @@ func TestApplyDefaultCORS_AddsHeaderWhenOriginSet(t *testing.T) {
if got := resp.Header.Get("Access-Control-Allow-Origin"); got != origin {
t.Fatalf("expected fallback origin header, got %q", got)
}
if got := resp.Header.Get("Access-Control-Expose-Headers"); got != "ETag" {
t.Fatalf("expected expose headers to include ETag, got %q", got)
if got := resp.Header.Get("Access-Control-Expose-Headers"); got != "ETag, x-amz-storage-class" {
t.Fatalf("expected expose headers to include ETag and x-amz-storage-class, got %q", got)
}
}