mirrors/versitygw
1
0
Fork 0
mirror of https://github.com/versity/versitygw.git synced 2026-04-22 21:50:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2046 from versity/ben/windows-sidecar

Browse Source 
fix: close temp file before rename in sidecar StoreAttribute
This commit is contained in:
Ben McClelland
2026-04-15 12:33:06 -07:00
committed by GitHub
parent 32fda8a144 81f0158a48
commit e8680bde63
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
backend/meta/sidecar.go
View File

@@ -80,13 +80,19 @@ func (s SideCar) StoreAttribute(_ *os.File, bucket, object, attribute string, va
return fmt.Errorf("failed to create temporary file: %v", err)
}
defer os.Remove(tempfile.Name())
defer tempfile.Close()
_, err = tempfile.Write(value)
if err != nil {
tempfile.Close()
return fmt.Errorf("failed to write attribute: %v", err)
}
// Close explicitly before rename to prevent error on Windows:
// The process cannot access the file because it is being used by another process.
if err = tempfile.Close(); err != nil {
return fmt.Errorf("failed to close temporary file: %v", err)
}
err = os.Rename(tempfile.Name(), attr)
if err != nil {
return fmt.Errorf("failed to rename temporary file: %v", err)