mirror of
https://github.com/versity/versitygw.git
synced 2026-07-02 16:54:25 +00:00
Sebastien Tardif
50e64f7e78
Add missing return statements after error checks in sendLog. When json.Marshal or http.NewRequest fails, the error is logged but execution continues. If http.NewRequest returns a nil *Request, the subsequent req.Header.Set call panics with a nil pointer dereference. This bug was introduced in PR #129 (2023-07-14) and has been present for nearly 3 years. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
25 lines
887 B
Go
25 lines
887 B
Go
// Copyright 2023 Versity Software
|
|
// This file is licensed under the Apache License, Version 2.0
|
|
// (the "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
package s3log
|
|
|
|
import "testing"
|
|
|
|
func TestSendLog_InvalidURL_NoPanic(t *testing.T) {
|
|
wl := &WebhookLogger{url: "://invalid"}
|
|
// sendLog must not panic when http.NewRequest fails due to
|
|
// an invalid URL. Before the fix, the nil req was dereferenced.
|
|
wl.sendLog(LogFields{})
|
|
}
|