Commit Graph
66 Commits
Author SHA1 Message Date
Andrew Wood d06374a0f1 Addressed more issues raised by splint and flawfinder. 2023-10-22 00:08:35 +01:00
Andrew Wood 9a9c117411 Addressed more issues raised by flawfinder. 2023-10-18 23:10:29 +01:00
Andrew Wood 3fdf8d5a69 Improved comments. 2023-10-16 22:47:02 +01:00
Andrew Wood b4d6c5ed2a Addressed more issues raised by splint, and improved variable names and comments. 2023-10-15 23:42:04 +01:00
Andrew Wood d8e0674da0 Move locally scoped variables from "switch" statement into outer "for" loop, to avoid triggering a crash in the "splint" code analyser. 2023-10-15 22:29:37 +01:00
Andrew Wood b0df2e53a8 Replace str_* in state structure with an array of components of enumerated types, to avoid pointers everywhere in the format array and to allow for later expansion which will separate "string length" from "displayed width" to allow for wide character support. 2023-10-14 17:18:20 +01:00
Andrew Wood 94ffdaf60d Group state structure into sub-structures to allow future changes to watchpid code that will do a better job of duplicating the relevant parts of the internal state for each fd. 2023-10-14 01:23:54 +01:00
Andrew Wood 03d42555e7 Addressed more issues raised by splint. 2023-10-14 00:04:24 +01:00
Andrew Wood 41b223a757 Addressed more issues raised by splint. 2023-10-13 23:31:28 +01:00
Andrew Wood e864eca78d Only check for the IPC functions we are still using. 2023-10-01 15:16:31 +01:00
Andrew Wood 0e1750835e Rewrite of "--remote", to use a temporary file for information exchange instead of a SysV IPC message queue, to correct the fault where "make check -j32" would fail due to every PV exit removing the message queue. 2023-10-01 01:20:16 +01:00
Andrew Wood e5cc71b4d2 Switched licensing to GPLv3+. 2023-09-24 21:09:52 +01:00
Andrew Wood 2033c6085f Addressed more issues raised by splint. 2023-09-23 21:53:31 +01:00
Andrew Wood 780b65a648 More type corrections. 2023-09-16 23:14:16 +01:00
Andrew Wood 20b8c9700a Rename the functions to better describe what they do, remove single-letter variable names, add more explanatory comments, remove "_t" suffix from typedef as per FreeBSD style guide. 2023-09-16 00:55:40 +01:00
Andrew Wood 252213fbc2 Addressed more issues raised by splint, and corrected some type confusion between off_t and size_t / ssize_t. 2023-09-14 22:19:49 +01:00
Andrew Wood e696b737e3 Addressed more issues raised by splint. 2023-09-13 23:50:20 +01:00
Andrew Wood 153285bec0 Use off_t for file sizes, size_t for buffer sizes. 2023-09-13 23:17:53 +01:00
Andrew Wood 8a2ddac50e Type consistency corrections - use booleans for boolean operations, use size_t for byte counts. 2023-09-12 23:42:23 +01:00
Andrew Wood 052c182278 Adjustments in line with "autoscan" recommendations. 2023-09-12 21:26:24 +01:00
Andrew Wood df67cee38a Addressed more issues raised by splint. 2023-09-11 23:06:57 +01:00
Andrew Wood 896727b664 Addressed the issues raised by splint and flawfinder. 2023-09-10 23:04:43 +01:00
Andrew Wood e8dab7daf7 Addressed more issues raised by splint. 2023-09-07 22:59:19 +01:00
Andrew Wood e7c332ad0b Addressed more issues raised by splint. 2023-09-06 23:32:34 +01:00
Andrew Wood 2a8e6b36b3 Addressed more issues raised by splint. 2023-09-05 23:36:01 +01:00
Andrew Wood befcddc994 Address warnings raised by splint. 2023-09-03 16:02:00 +01:00
Andrew Wood 86feafb721 Rename "doc" directory to "docs" to match Debian standards. 2023-09-03 00:40:26 +01:00
Andrew Wood 78bb93b288 Move terminal TOSTOP attribute changes into signal handling functions and only set/unset that attribute rather than saving and restoring the whole terminal state; keep track of whether we have changed it and change cursor positioning IPC data to a structure so the state change can be shared with all "pv -c" instances. 2023-09-02 22:06:31 +01:00
Andrew Wood 14ce832249 New "--error-skip-block" option. 2023-09-02 01:21:18 +01:00
Andrew Wood d51a1b10f0 Corrections to file header comments. 2023-08-31 21:49:27 +01:00
Andrew Wood 1f320dd7a2 Replace all gettimeofday() calls, and elapsed time arithmetic, with a new set of elapsed time functions based on clock_gettime(), to avoid faults due to time zone / DST changes and machine suspend/resume. 2023-08-30 22:23:43 +01:00
Andrew Wood b7eb3c9e90 Record whether the width or height were set manually, and refrain from changing a manually set value when the terminal size changes. 2023-08-28 22:03:14 +01:00
Andrew Wood 9e5bdeb3a4 Added "--discard" option. 2023-08-28 21:05:45 +01:00
Andrew Wood 0bd1b82d3a Move libgen.h out of IPC conditional code since it is not related directly to IPC; adjust IPC configuration so that IPC support is auto-disabled if the relevant header files or library functions are missing. 2023-08-28 17:44:53 +01:00
Andrew Wood 2a092c9495 Rename "null" state boolean to "null_terminated_lines" so it is more descriptive and less confusing. 2023-08-28 16:18:51 +01:00
Andrew Wood 66cae656d1 Rename state variable "no_op" to the more descriptive "no_display", as pv is not doing nothing when this is set, it is still transferring data. 2023-08-28 15:20:51 +01:00
Andrew Wood b1ef744058 Use posix_fadvise() on input files, where available. 2023-08-28 13:10:38 +01:00
Andrew Wood e99548ea8a Major restructuring to switch build system from old scripts to GNU Automake. 2023-08-28 10:04:39 +01:00
Andrew Wood fe22f0e449 Store name and format string in internal state as their own copies rather than pointers to strings outside the state, for memory safety and to avoid a leak on remote control. 2023-08-26 20:49:30 +01:00
Andrew Wood 4cd28b23f0 Adjustments and annotations as per splint and flawfinder reports. 2023-08-14 23:07:37 +01:00
Andrew Wood cc4d1a15e4 Make the filenames in the list constant. 2023-08-14 22:37:23 +01:00
Andrew Wood 7f25aff91d Adjustments and annotations as per splint and flawfinder reports. 2023-08-14 22:33:06 +01:00
Andrew Wood f01117d84e Adjustments and annotations as per splint and flawfinder reports. 2023-08-14 20:56:11 +01:00
Andrew Wood 34fe796806 Refactored "--help" to support multi-byte character locales when word wrapping, and clear all "splint" and "flawfinder" warnings. 2023-07-29 21:32:34 +01:00
Andrew Wood b9f96d9508 Provide new option "--debug" instead of using insecure environment variable DEBUG. 2023-07-28 23:14:14 +01:00
Andrew Wood cd9f057f15 Removed incorrect undef HAVE_STDBOOL_H which caused standard boolean types to be redefined unnecessarily. 2023-07-28 21:55:57 +01:00
Andrew Wood ae81f83e9b New option "--direct-io". 2023-07-27 21:44:30 +01:00
Andrew Wood 6cff3c1c2a First draft of new "--sync" option. 2023-07-26 22:17:00 +01:00
Andrew Wood c7e0bb727e Introduce strlcat() instead of strcat(), and replace all sizeof() of buffers inside structures with constants where possible, to avoid bugs caused by reading the size of a pointer instead of the size of the buffer it points to. 2023-07-23 01:57:00 +01:00
Andrew Wood e94600d7a4 Put all terminal writes through the same pv_write_retry function for consistency and to clear up compiler warnings. 2023-07-22 23:22:34 +01:00