mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-21 04:31:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,157 Commits 26 Branches 11 Tags
5c5d93b15d2cf66d814e69413121dcf0bd40da31
Commit Graph

4157 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bart Van Assche
5c5d93b15d scst_vdisk: Build fix for kernel versions < 2.6.37 
See also r5420 / r5479.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5506 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-05-07 08:57:04 +00:00
Bart Van Assche
f3d2fadbac scst: Fix the procfs build 
Move the definition of scst_get_opcode_name() up such that it occurs
outside #ifndef CONFIG_SCST_PROC / #endif. See also r5491.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5505 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-05-07 08:38:47 +00:00
Vladislav Bolkhovitin
5e40f25182 Fix COMMAND DATA LENGTH in All_commands parameter data of REPORT SUPPORTED OPERATION CODES 
Reported by Sebastian Herbszt <herbszt@gmx.de>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5504 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-05-07 02:13:11 +00:00
Vladislav Bolkhovitin
8d4a2f0a49 Cleanups and logging improvements 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5503 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-05-06 23:22:32 +00:00
Vladislav Bolkhovitin
d6a46f9d73 scst_sysfs: Save the value of the 'preferred' attribute only if it has been set 
The default value of the 'preferred' attribute is 0 (disabled). Hence
it is only necessary that scstadmin saves the value of that attribute
if it is not zero.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5502 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-05-02 02:56:19 +00:00
Vladislav Bolkhovitin
5bbff95426 Cleanups 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5501 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-05-02 02:50:34 +00:00
Vladislav Bolkhovitin
f2d67c085b Fix CDROM empty case 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5500 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-05-02 02:50:12 +00:00
Bart Van Assche
8385d3b5a7 nightly build: Update kernel versions 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5499 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-30 06:01:17 +00:00
Bart Van Assche
d3d094d160 ib_srpt: Fix two recently introduced checkpatch complaints about whitespace 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5498 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-30 05:30:45 +00:00
Vladislav Bolkhovitin
53af3de6e4 Cleanup 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5497 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-30 01:07:41 +00:00
Vladislav Bolkhovitin
a6832beba4 Extended INQUIRY page added 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5496 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-30 01:04:27 +00:00
Bart Van Assche
424b231e96 ib_srpt: Make LUN masking work again 
This patch fixes a regression that was introduced in r5493.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5495 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-29 12:39:50 +00:00
Bart Van Assche
607487caca ib_srpt, README: Fix RDMA/CM login instructions 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5494 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-29 12:35:41 +00:00
Vladislav Bolkhovitin
bea1b78f4a Minor logging improvement 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5493 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-29 02:09:29 +00:00
Vladislav Bolkhovitin
7150fc35f2 Missed hunk in the previous commit 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5492 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-29 01:45:43 +00:00
Vladislav Bolkhovitin
86db759148 SCSI logging improvements 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5491 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-29 01:32:13 +00:00
Vladislav Bolkhovitin
d51053c5d9 It's wrong to clean reservation on failed RESERVE commands 
With multiple outstanding commands it can open a race window leading to
loose of a valid reservation



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5490 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-29 00:13:24 +00:00
Vladislav Bolkhovitin
8a53a54081 Let REPORT SUPPORTED OPERATION CODES be handled by dev handler as well 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5489 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-28 22:30:03 +00:00
Vladislav Bolkhovitin
7c4b3c0d0c Returned sense cleanups 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5488 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-28 21:38:22 +00:00
Vladislav Bolkhovitin
0f2bd5f409 Cleanups 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5487 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-28 20:31:14 +00:00
Bart Van Assche
9ee828de16 scst: Export scst_path_put() 
This patch makes the code that was added via r5479 build against kernel
version 2.6.38 and before.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5485 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-28 09:29:25 +00:00
Bart Van Assche
c2020a81b4 scst_const.h: Fix a checkpatch complaint about whitespace 
Avoid that checkpatch reports the following warning message:

WARNING: please, no space before tabs


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5484 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-27 06:26:29 +00:00
Bart Van Assche
3baf34908f scst: Fix recently introduced checkpatch complaints about whitespace 
Fix two instances of the following checkpatch errors:

ERROR: code indent should use tabs where possible
ERROR: spaces required around that ':' (ctx:VxW)


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5483 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-26 06:32:32 +00:00
Vladislav Bolkhovitin
72a57986e5 Cleanups 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5482 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-26 02:12:17 +00:00
Vladislav Bolkhovitin
34f682c19e Processing of QErr and TMF_ONLY added 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5481 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-26 01:56:36 +00:00
Vladislav Bolkhovitin
c0be3de584 Follow up for the previous commit 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5480 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-25 02:47:31 +00:00
Vladislav Bolkhovitin
160016b9e8 Saved mode pages added 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5479 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-25 02:03:04 +00:00
Vladislav Bolkhovitin
13ec92196f Cleanup 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5478 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 23:44:25 +00:00
Vladislav Bolkhovitin
40161eeb10 Minor logging cleanup 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5477 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 23:07:58 +00:00
Bart Van Assche
e7179af46b scst: Avoid that reassigning a session triggers a kernel crash 
This patch fixes the following kernel bug:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000064
IP: [<ffffffffa069e59c>] scst_alloc_add_tgt_dev+0x9c/0x540 [scst]
Call Trace:
 [<ffffffffa06a1b57>] scst_check_reassign_sessions+0x367/0x3b0 [scst]
 [<ffffffffa06a1cb7>] scst_acg_add_acn+0x117/0x1a0 [scst]
 [<ffffffffa06a5e42>] scst_acg_ini_mgmt_store_work_fn+0x152/0x370 [scst]
 [<ffffffffa06a93a6>] sysfs_work_thread_fn+0xa6/0x2f0 [scst]
 [<ffffffff8108dd72>] kthread+0xd2/0xf0
 [<ffffffff816912bc>] ret_from_fork+0x7c/0xb0

Reported-by: Zhen Xu <zhenxu.zj@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5476 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 18:49:52 +00:00
Bart Van Assche
7922cc2dfb scstadmin, regression tests: Follow-up for r5409 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5475 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 18:45:23 +00:00
Bart Van Assche
6cbe580d89 ib_srpt: Unload properly with RDMA/CM disabled 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5474 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 18:43:41 +00:00
Bart Van Assche
99b7abe259 ib_srpt, Makefile: Introduce the OFED_KERNEL_DIR variable 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5473 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 12:27:00 +00:00
Bart Van Assche
eae0318512 ib_srpt: Make srpt_disconnect_ch() close sessions properly that have not yet reached the connected state 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5472 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 11:11:26 +00:00
Bart Van Assche
cd0dcb32ab ib_srpt: Add support in the Makefile for MLNX OFED and for OFED 3.x 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5471 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 10:38:37 +00:00
Bart Van Assche
a4a01d6675 ib_srpt: OFED 3.12 build fix 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5470 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 10:37:58 +00:00
Bart Van Assche
ee394389e2 scst/README: Update multipathd information in implicit ALUA section 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5469 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 08:41:15 +00:00
Vladislav Bolkhovitin
1249be6247 Fix for TARGET RESET race 
It can happen, when a device added after blocking, so unblocking then
will make dev->block_count of the new device negative.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5468 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 04:03:51 +00:00
Vladislav Bolkhovitin
d3fcdde388 Fix queuing of UA for aborted by PREEMPT AND ABORT, if TAS is 0, + some clarifications 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5467 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 03:15:12 +00:00
Vladislav Bolkhovitin
6b020ed078 scst: Avoid that smatch complains about dead code 
The panic() function that implements BUG() has been declared with attribute
noreturn in some RHEL 5 kernel headers and also in the RHEL 6 kernel headers.
Smatch warns about dead code if any code follows a function that has been
declared with attribute noreturn. Hence add a few preprocessor statements to
suppress the smatch warning when building against an upstream kernel or when
building against RHEL 6 or later.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5466 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 02:39:05 +00:00
Vladislav Bolkhovitin
476e5968a4 scst_targ: Clarify a comment 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5465 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 02:33:07 +00:00
Vladislav Bolkhovitin
9f3c9df526 scst_lib: Avoid integer overflows 
This patch fixes the following kernel oops:

[3696]: scst: scst_parse_cmd:826:Warning: expected transfer length 522240 for opcode 0x08 (handler vcdrom, target iscsi) doesn't match decoded value -2048
[3696]: scst_parse_cmd:828:Suspicious CDB:
 (h)___0__1__2__3__4__5__6__7__8__9__A__B__C__D__E__F
   0: 08 1f ff ff ff 00   ......
BUG: unable to handle kernel paging request at ffff88283597f0c8
IP: [<ffffffff8135c3af>] sg_init_table+0x5f/0x90
Call Trace:
 [<ffffffffa021eb48>] sgv_pool_alloc+0x3b8/0xbf0 [scst]
 [<ffffffffa0204c16>] scst_alloc_space+0xb6/0x290 [scst]
 [<ffffffffa01e2d28>] scst_prepare_space+0x3b8/0x6e0 [scst]
 [<ffffffffa01ef4a5>] scst_process_active_cmd+0x455/0x7e0 [scst]
 [<ffffffffa01efb22>] scst_cmd_init_done+0x2f2/0x5c0 [scst]
 [<ffffffffa0156ac2>] scst_cmd_init_stage1_done.constprop.37+0x12/0x20 [iscsi_scst]
 [<ffffffffa015d9fa>] scsi_cmnd_start+0x25a/0x550 [iscsi_scst]
 [<ffffffffa015e4b8>] cmnd_rx_start+0x148/0x1a0 [iscsi_scst]
 [<ffffffffa0161598>] process_read_io+0x3b8/0x800 [iscsi_scst]
 [<ffffffffa0161aa7>] scst_do_job_rd+0xc7/0x220 [iscsi_scst]
 [<ffffffffa016208d>] istrd+0x16d/0x2e0 [iscsi_scst]
 [<ffffffff81075bad>] kthread+0xed/0x110
 [<ffffffff816dd5bc>] ret_from_fork+0x7c/0xb0

and causes the following message to be reported instead:

[11269]: scst: scst_generic_parse:7402:***WARNING***: bufflen 16777215, data_len 16777215 or out_bufflen 0 too large for device disk12 (block size 2048)
scst_generic_parse:CDB:
 (h)___0__1__2__3__4__5__6__7__8__9__A__B__C__D__E__F
   0: 08 1f ff ff ff 00   ......

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5464 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 02:30:52 +00:00
Vladislav Bolkhovitin
77d9940242 Cleanups 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5463 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-24 00:07:22 +00:00
Bart Van Assche
54a84dff08 ib_srpt: Clean up the CM event handling messages (part 3) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5462 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-23 13:38:54 +00:00
Bart Van Assche
4181477639 ib_srpt: RHEL 5.9 build fix (part 2) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5461 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-23 09:20:52 +00:00
Bart Van Assche
3f76f4e792 ib_srpt, RDMA/CM: Avoid hanging sessions due to a cable pull 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5460 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-23 09:04:15 +00:00
Bart Van Assche
05c8c1548c ib_srpt: Clean up the CM event handling code (part 2) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5459 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-23 09:02:29 +00:00
Bart Van Assche
8fd1252268 ib_srpt: Clean up the CM event handling code 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5458 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-23 08:59:18 +00:00
Bart Van Assche
dafaa63ea0 ib_srpt: RHEL 5.9 build fix 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5457 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-23 08:57:17 +00:00
Bart Van Assche
ec7188eb2a scst/README: Update implicit ALUA section 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5456 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-04-23 05:15:57 +00:00