Commit Graph

4699 Commits

Author SHA1 Message Date
Bart Van Assche 993f290908 isert-scst: Port this driver to RHEL 5
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6416 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-10 22:27:37 +00:00
Bart Van Assche ae9de304c4 scst: Several RHEL 5 build fixes
Move the get_unaligned_*() functions up such that these occur
before the T10-PI functions. Backport the definition of
VARIABLE_LENGTH_CMD. Make scst_dif_crc_fn() build on RHEL 5
systems.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6415 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-10 22:26:43 +00:00
Bart Van Assche f92a917d45 iscsi-scst: Suppress strict aliasing compiler warnings
Avoid that the compiler reports warnings about strict aliasing when
building iscsi-scst on RHEL 6. This patch does not change any
functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6414 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-10 22:22:57 +00:00
Bart Van Assche 84d90ac96e scst.h: Backport more cpumask.h functions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6413 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-10 16:04:27 +00:00
Bart Van Assche ac156d84c0 scst.h: Add cpumask_var_t for kernel versions before 2.6.28
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6412 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-09 19:12:09 +00:00
Bart Van Assche 44542c9752 ib_srpt: Follow-up for r6410
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6411 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-09 19:11:04 +00:00
Bart Van Assche b448c6edf4 ib_srpt: Add support for systems with more than 64 CPU's
Avoid that the following warning is reported on systems with more
than 64 CPU's:

WARNING: CPU: 0 PID: 4762 at drivers/scst/srpt/ib_srpt.c:4179 init_module+0x1d8f42/0x1db887 [ib_srpt]()
Call Trace:
 [<ffffffff8154f2ed>] dump_stack+0x46/0x58
 [<ffffffff8104b4ec>] warn_slowpath_common+0x8c/0xc0
 [<ffffffff8104b53a>] warn_slowpath_null+0x1a/0x20
 [<ffffffffa0236f42>] init_module+0x1d8f42/0x1db887 [ib_srpt]
 [<ffffffffa0233000>] ? 0xffffffffa0233000
 [<ffffffffa005e000>] ? 0xffffffffa005e000
 [<ffffffffa015d587>] ib_register_client+0x87/0xc0 [ib_core]
 [<ffffffffa005e0ef>] init_module+0xef/0x1000 [ib_srpt]
 [<ffffffffa005e000>] ? 0xffffffffa005e000
 [<ffffffff810002bc>] do_one_initcall+0x8c/0x1c0
 [<ffffffff81149022>] ? __vunmap+0xc2/0x110
 [<ffffffff810bb3e3>] load_module+0x1b03/0x22a0
 [<ffffffff810b7e80>] ? show_initstate+0x60/0x60
 [<ffffffff810bbcce>] SyS_finit_module+0x8e/0x90
 [<ffffffff81555a32>] system_call_fastpath+0x12/0x17

Reported-by: Jack Wang <xjtuwjp@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6410 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-08 18:23:24 +00:00
Bart Van Assche ea8f0a8afb nightly build: Add kernel version 4.1
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6409 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-08 15:41:22 +00:00
Vladislav Bolkhovitin 1656efe689 iscsi-scst: small post-r6315 cleanup
Avoid that rd_task declared when it is not used



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6408 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-03 04:21:52 +00:00
Vladislav Bolkhovitin 3949bfa445 scst_vdisk: fix typo in vdisk_get_supported_opcodes()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6407 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-01 22:13:40 +00:00
Bart Van Assche ce6721207e nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6406 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-30 01:11:54 +00:00
Bart Van Assche 2e07fca500 nightly build: Add kernel v4.1 build infrastructure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6405 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-28 15:45:59 +00:00
Bart Van Assche 12566f2781 nightly build: Update a kernel version
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6404 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-28 05:24:49 +00:00
Bart Van Assche ef8d3ae376 nightly build: Update a kernel version
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6403 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-26 20:21:09 +00:00
Bart Van Assche 75369451a5 isert-scst/Kconfig: Add InfiniBand dependency
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6402 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-25 14:12:54 +00:00
Bart Van Assche e3c906b4e5 scripts/run-regression-tests: Filter line numbers from the smatch output
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6400 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-24 15:18:48 +00:00
Bart Van Assche 2b209aedcd nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6398 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-24 03:24:37 +00:00
Bart Van Assche 79c8bf1f7c iscsi-scst, isert-scst: One trace flags variable per kernel module
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6397 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-23 15:01:17 +00:00
Bart Van Assche f0e98ee4b2 isert-scst: Build fix for older kernel versions (< 2.6.29)
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6395 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-19 14:06:05 +00:00
Vladislav Bolkhovitin 3b124eb309 Fix NDOB parsing for WRITE_SAME32
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6394 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-18 01:43:47 +00:00
Bart Van Assche 46915ef3e5 iscsi-scst: Fix a syntax error
Preprocessor directives are not allowed in argument lists of a macro.
This patch reverts r6317.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6393 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 05:00:20 +00:00
Bart Van Assche cd0a7b7b9d qla2x00t: Fix a potential buffer overflow
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6392 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:36:52 +00:00
Bart Van Assche 7b8ad56790 qla2x00t: Fix a potential buffer overflow
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6391 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:36:22 +00:00
Bart Van Assche 2a6a25ba45 qla2x00t: Change type of first argument of qla24xx_prep_ct_fm_req()
This makes it easier for Coverity to analyze this code.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6390 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:35:43 +00:00
Bart Van Assche 11df045449 iscsiadm: Fix a resource leak in an error path
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6389 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:32:53 +00:00
Bart Van Assche bb0a7c894a iscsi-scstd: Annotate a fall-through for Coverity
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6388 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:32:27 +00:00
Bart Van Assche 476d0ba898 iscsi-scstd: Constify several function arguments
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6387 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:32:02 +00:00
Bart Van Assche f05dfcf88f iscsi-scstd: Suppress a compiler warning
Avoid that gcc reports the following compiler warning:
    
message.c:197:44: warning: 'rsp_data_sz' may be used uninitialized in this function [-Wmaybe-uninitialized]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6386 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:31:20 +00:00
Bart Van Assche 8a4e41fb44 iscsi-scstd: Allow the compiler to inline functions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6385 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:30:40 +00:00
Bart Van Assche 4ad34f74d5 fileio: Fix a potential buffer overflow
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6384 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:30:16 +00:00
Bart Van Assche 556023b862 qla2x00t: Help Coverity with analyzing ct_sns_pkt initialization
This patch does not change any functionality. See also the upstream
patch "qla2xxx: Help Coverity with analyzing ct_sns_pkt
initialization".


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6383 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:29:40 +00:00
Bart Van Assche 18c63e434b qla2x00t: Fix a potential buffer overflow
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6382 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:29:04 +00:00
Bart Van Assche e2210ff40f ib_srpt, make clean: Remove all temporary files
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6381 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:28:39 +00:00
Bart Van Assche a8da0107f8 iscsiadm: Fix a resource leak
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6380 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:28:02 +00:00
Bart Van Assche ad38432332 iscsiadm: Fix strerror() argument
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6379 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:27:41 +00:00
Bart Van Assche a14df39942 iscsiadm: Do not allocate more memory than needed
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6378 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:27:18 +00:00
Bart Van Assche ff2b660264 iscsiadm: Fix a file descriptor leak in an error path
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6377 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:26:35 +00:00
Bart Van Assche f5f85b95fb iscsi-scstd: Fix a resource leak in an error path
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6376 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:26:08 +00:00
Bart Van Assche a6121b03c8 iscsi-scstd: Fix a potential file descriptor leak
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6375 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:25:42 +00:00
Bart Van Assche 74b4104994 iscsi-scstd: Avoid that Coverity complains about a use-after-free
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6374 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:25:05 +00:00
Bart Van Assche b3f49a0a17 iscsi-scstd: Annotate fall-throughs for Coverity
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6373 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:24:25 +00:00
Bart Van Assche 102d8d54c9 iscsi-scstd: Move two local variables to suppress a Coverity complaint
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6372 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:24:03 +00:00
Bart Van Assche 41caee3148 iscsi-scstd: Fix a file descriptor leak in an error path
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6371 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:23:38 +00:00
Bart Van Assche 21b60063a9 iscsi-scstd: Fix a dereference-before-null-check
Detected by Coverity.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6370 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:23:14 +00:00
Bart Van Assche b099782023 iscsi-scstd: Fix a memory leak in the iSNS code
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6369 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:22:46 +00:00
Bart Van Assche dfcb53a9b2 iscsi-scstd: Rearrange driver major number lookup code
Introduce a function for looking up the driver major number.
This patch does not change any functionality but makes the source
code easier to read and also makes it easier for Coverity to
analyze this code.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6368 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:22:14 +00:00
Bart Van Assche 165b0f1d10 iscsi-scstd: Improve create_and_open_dev() robustness
Reset 'devn' if the sscanf() return value is lower than two.
Based on a Coverity report.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6367 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:21:28 +00:00
Bart Van Assche d70b1e39c0 iscsi-scstd: Fix a dereference-before-null-check
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6366 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:20:21 +00:00
Bart Van Assche 40a90a705d isert-scst: Add address length check in isert_listen_ioctl()
Detected by Coverity.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6365 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:19:27 +00:00
Bart Van Assche 26cda0eb38 iscsi-scst: Annotate fall-through cases for Coverity
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6364 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:18:23 +00:00