mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-22 05:01:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,940 Commits 26 Branches 11 Tags
bd3aa5d4a56ee39b26f84b37deced41359eb1bde
Commit Graph

6940 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bart Van Assche
bd3aa5d4a5 iscsi-scst: Port to Linux kernel v5.9 
In Linux kernel v5.9 use of the KERNEL_SOCKPTR() function is mandatory
when calling setsockopt(). Implement that function for kernels before v5.9.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9149 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 21:16:47 +00:00
Bart Van Assche
10ede52dd9 nightly build: Update kernel versions 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9148 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 16:11:39 +00:00
Bart Van Assche
ac08491d6a scst/include/backport.h: Backport the fallthrough macro 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9147 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 16:11:31 +00:00
Bart Van Assche
bb63af5901 qla2xxx: Fix wrong return value in qla_nvme_register_hba() 
On an error exit path, a negative error code should be returned instead of
a positive return value.

Link: https://lore.kernel.org/r/20200802111530.5020-1-tianjia.zhang@linux.alibaba.com
Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit ca4fb89a3d714a770e9c73c649da830f3f4a5326.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9146 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 16:04:14 +00:00
Bart Van Assche
d3c5f58492 qla2x00t-32gbit: Fix wrong return value in qlt_chk_unresolv_exchg() 
In the case of a failed retry, a positive value EIO is returned here.  I
think this is a typo error. It is necessary to return an error value.

[mkp: caller checks != 0 but the rest of the file uses -Exxx so fix this up
to be consistent]

Link: https://lore.kernel.org/r/20200802111528.4974-1-tianjia.zhang@linux.alibaba.com
Fixes: 0691094ff3f2 ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit bbf2d06a9d767718bfe6028d6288c03edb98554a.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9145 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 16:03:37 +00:00
Bart Van Assche
75687c6513 qla2x00t-32gbit: Remove redundant variable initialization 
The initialization value of `rc` is wrong. It is unnecessary to initialize
`rc` variables, so remove its initialization operation.

Link: https://lore.kernel.org/r/20200802111527.4928-1-tianjia.zhang@linux.alibaba.com
Fixes: 84905dfe78d2 ("scsi: qla2xxx: Fix TMF and Multi-Queue config")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 8905cbdae986515c5a4dcd71889672235478f189.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9144 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 16:02:48 +00:00
Bart Van Assche
735be2120c qla2x00t-32gbit: Fix the size used in a 'dma_free_coherent()' call 
Update the size used in 'dma_free_coherent()' in order to match the one
used in the corresponding 'dma_alloc_coherent()'.

[mkp: removed memset() hunk that has already been addressed]
    
Link: https://lore.kernel.org/r/20200802110721.677707-1-christophe.jaillet@wanadoo.fr
Fixes: 4161cee52df8 ("[SCSI] qla4xxx: Add host statistics support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 650b323c8e7c3ac4830a20895b1d444fd68dd787.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9143 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 16:02:06 +00:00
Bart Van Assche
9b6e29baff qla2x00t-32gbit: Remove pci-dma-compat wrapper API 
Link: https://lore.kernel.org/r/24627a86cf1e67fd229bc323316523d1ba0811f9.1596045683.git.usuraj35@gmail.com
Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 8d1f1ffaeb27ca81ea0dd24e238015efee7b5924.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9142 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 16:01:22 +00:00
Bart Van Assche
22ca3580da qla2x00t-32gbit: Remove superfluous memset() 
Fixes coccicheck warning:

./drivers/scsi/qla2xxx/qla_mbx.c:4928:15-33: WARNING: dma_alloc_coherent use in els_cmd_map already zeroes out memory,  so memset is not needed

dma_alloc_coherent() already zeroes out memory so memset() is not needed.

Link: https://lore.kernel.org/r/1596079918-41115-3-git-send-email-liheng40@huawei.com
Signed-off-by: Li Heng <liheng40@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit bef93fbfcf4ae9ecaa50e38d32cf6b8dbce4a797.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9141 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 16:00:15 +00:00
Bart Van Assche
f872ffa8a9 iscsi-scst/kernel/isert-scst/Kbuild: Fix the isert-scst build 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9140 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:52:09 +00:00
Bart Van Assche
d923eed64b qla2x00t-32gbit: Use fallthrough pseudo keyword 
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

See also upstream commit dca93232b361d260413933903cd4bdbd92ebcc7f.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9139 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:47:45 +00:00
Bart Van Assche
9b2f2a4a71 qla2x00t-32gbit: Revert "Disable T10-DIF feature with FC-NVMe during probe" 
FCP T10-PI and NVMe features are independent of each other. This patch
allows both features to co-exist.

This reverts commit 5da05a26b8305a625bc9d537671b981795b46dab.

Link: https://lore.kernel.org/r/20200806111014.28434-12-njavali@marvell.com
Fixes: 5da05a26b830 ("scsi: qla2xxx: Disable T10-DIF feature with FC-NVMe during probe")
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit dca93232b361d260413933903cd4bdbd92ebcc7f.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9138 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:46:48 +00:00
Bart Van Assche
e2451f62db qla2x00t-32gbit: Revert "Fix crash on qla2x00_mailbox_command" 
FCoE adapter initialization failed for ISP8021 with the following patch
applied. In addition, reproduction of the issue the patch originally tried
to address has been unsuccessful.

This reverts commit 3cb182b3fa8b7a61f05c671525494697cba39c6a.

Link: https://lore.kernel.org/r/20200806111014.28434-11-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit de7e6194301ad31c4ce95395eb678e51a1b907e5.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9137 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:46:03 +00:00
Bart Van Assche
05cc5a7aab qla2x00t-32gbit: Fix null pointer access during disconnect from subsystem 
NVMEAsync command is being submitted to QLA while the same NVMe controller
is in the middle of reset. The reset path has deleted the association and
freed aen_op->fcp_req.private. Add a check for this private pointer before
issuing the command.

...
 6 [ffffb656ca11fce0] page_fault at ffffffff8c00114e
    [exception RIP: qla_nvme_post_cmd+394]
    RIP: ffffffffc0d012ba  RSP: ffffb656ca11fd98  RFLAGS: 00010206
    RAX: ffff8fb039eda228  RBX: ffff8fb039eda200  RCX: 00000000000da161
    RDX: ffffffffc0d4d0f0  RSI: ffffffffc0d26c9b  RDI: ffff8fb039eda220
    RBP: 0000000000000013   R8: ffff8fb47ff6aa80   R9: 0000000000000002
    R10: 0000000000000000  R11: ffffb656ca11fdc8  R12: ffff8fb27d04a3b0
    R13: ffff8fc46dd98a58  R14: 0000000000000000  R15: ffff8fc4540f0000
    ORIG_RAX: ffffffffffffffff  CS: 0010  SS: 0018
 7 [ffffb656ca11fe08] nvme_fc_start_fcp_op at ffffffffc0241568 [nvme_fc]
 8 [ffffb656ca11fe50] nvme_fc_submit_async_event at ffffffffc0241901 [nvme_fc]
 9 [ffffb656ca11fe68] nvme_async_event_work at ffffffffc014543d [nvme_core]
10 [ffffb656ca11fe98] process_one_work at ffffffff8b6cd437
11 [ffffb656ca11fed8] worker_thread at ffffffff8b6cdcef
12 [ffffb656ca11ff10] kthread at ffffffff8b6d3402
13 [ffffb656ca11ff50] ret_from_fork at ffffffff8c000255

--
PID: 37824  TASK: ffff8fb033063d80  CPU: 20  COMMAND: "kworker/u97:451"
 0 [ffffb656ce1abc28] __schedule at ffffffff8be629e3
 1 [ffffb656ce1abcc8] schedule at ffffffff8be62fe8
 2 [ffffb656ce1abcd0] schedule_timeout at ffffffff8be671ed
 3 [ffffb656ce1abd70] wait_for_completion at ffffffff8be639cf
 4 [ffffb656ce1abdd0] flush_work at ffffffff8b6ce2d5
 5 [ffffb656ce1abe70] nvme_stop_ctrl at ffffffffc0144900 [nvme_core]
 6 [ffffb656ce1abe80] nvme_fc_reset_ctrl_work at ffffffffc0243445 [nvme_fc]
 7 [ffffb656ce1abe98] process_one_work at ffffffff8b6cd437
 8 [ffffb656ce1abed8] worker_thread at ffffffff8b6cdb50
 9 [ffffb656ce1abf10] kthread at ffffffff8b6d3402
10 [ffffb656ce1abf50] ret_from_fork at ffffffff8c000255

Link: https://lore.kernel.org/r/20200806111014.28434-10-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 83949613fac61e8e37eadf8275bf072342302f4e.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9136 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:45:14 +00:00
Bart Van Assche
3b4406ec4a qla2x00t-32gbit: Check if FW supports MQ before enabling 
OS boot during Boot from SAN was stuck at dracut emergency shell after
enabling NVMe driver parameter. For non-MQ support the driver was enabling
MQ. Add a check to confirm if FW supports MQ.

Link: https://lore.kernel.org/r/20200806111014.28434-9-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit dffa11453313a115157b19021cc2e27ea98e624c.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9135 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:44:15 +00:00
Bart Van Assche
49ba5cf318 qla2x00t-32gbit: Fix WARN_ON in qla_nvme_register_hba 
qla_nvme_register_hba() puts out a warning when there are not enough queue
pairs available for FC-NVME.  Just fail the NVME registration rather than a
WARNING + call Trace.

Link: https://lore.kernel.org/r/20200806111014.28434-8-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 897d68eb816bfae5ad9e870f68350dbb599d6e0e.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9134 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:43:39 +00:00
Bart Van Assche
426ee6a956 qla2x00t-32gbit: Allow ql2xextended_error_logging special value 1 to be set anytime 
ql2xextended_error_logging can now be set to 1 to get the default mask
value, as opposed to at module load time only.

Link: https://lore.kernel.org/r/20200806111014.28434-7-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 49030003a38a5e3688781e2ccf9550dcebf61282.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9133 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:43:07 +00:00
Bart Van Assche
c61452b67a qla2xxx-32gbit: Reduce noisy debug message 
Update debug level and message for ELS IOCB done.

Link: https://lore.kernel.org/r/20200806111014.28434-6-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 81b9d1e19d62bf876c3985dbaf53a3a50eedd74b.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9132 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:42:29 +00:00
Bart Van Assche
124ee51ee9 qla2xxx: Fix login timeout 
Multipath errors were seen during failback due to login timeout.  The
remote device sent LOGO, the local host tore down the session and did
relogin. The RSCN arrived indicates remote device is going through failover
after which the relogin is in a 20s timeout phase.  At this point the
driver is stuck in the relogin process.  Add a fix to delete the session as
part of abort/flush the login.

Link: https://lore.kernel.org/r/20200806111014.28434-5-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit abb31aeaa9b20680b0620b23fea5475ea4591e31.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9131 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:41:31 +00:00
Bart Van Assche
73a1b8cddf qla2x00t-32gbit: Indicate correct supported speeds for Mezz card 
Correct the supported speeds for 16G Mezz card.

Link: https://lore.kernel.org/r/20200806111014.28434-4-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 4709272f6327cc4a8ee1dc55771bcf9718346980.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9130 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:27:58 +00:00
Bart Van Assche
15a7fff96d qla2x00t-32gbit: Flush I/O on zone disable 
Perform implicit logout to flush I/O on zone disable.

Link: https://lore.kernel.org/r/20200806111014.28434-3-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit a117579d0205b5a0592a3a98493e2b875e4da236.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9129 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:27:04 +00:00
Bart Van Assche
e03244543a qla2x00t-32gbit: Flush all sessions on zone disable 
On Zone Disable, certain switches would ignore all commands. This causes
timeout for both switch scan command and abort of that command. On
detection of this condition, all sessions will be shutdown.

Link: https://lore.kernel.org/r/20200806111014.28434-2-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 10ae30ba664822f62de169a61628e31c999c7cc8.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9128 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:26:23 +00:00
Bart Van Assche
9ad05ec8e6 qla2x00t-32gbit: Use MBX_TOV_SECONDS for mailbox command timeout values 
Improves readability of qla_mbx.c.

Link: https://lore.kernel.org/r/20200805200546.22497-1-ematsumiya@suse.de
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit c314a014b1802d30f1dc50db18b2e7f5a77d19c6.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9127 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:25:34 +00:00
Bart Van Assche
f7c295ca26 qla2xxx: Fix a condition in qla2x00_find_all_fabric_devs() 
This code doesn't make sense unless the correct "fcport" was found.

Link: https://lore.kernel.org/r/20200619143041.GD267142@mwanda
Fixes: 9dd9686b1419 ("scsi: qla2xxx: Add changes for devloss timeout in driver")
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Shyam Sundar <ssundar@marvell.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 1fc98aaf7f85fadcca57c4a86ef17e1940cad2d3.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9126 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:24:52 +00:00
Bart Van Assche
b2b56e6eca qla2x00t-32gbit: Keep initiator ports after RSCN 
The driver performs SCR (state change registration) in all modes including
pure target mode.

For each RSCN, scan_needed flag is set in qla2x00_handle_rscn() for the
port mentioned in the RSCN and fabric rescan is scheduled. During the
rescan, GNN_FT handler, qla24xx_async_gnnft_done() deletes session of the
port that caused the RSCN.

In target mode, the session deletion has an impact on ATIO handler,
qlt_24xx_atio_pkt(). Target responds with SAM STATUS BUSY to I/O incoming
from the deleted session. qlt_handle_cmd_for_atio() and
qlt_handle_task_mgmt() return -EFAULT if they are not able to find session
of the command/TMF, and that results in invocation of qlt_send_busy():

  qlt_24xx_atio_pkt_all_vps: qla_target(0): type 6 ox_id 0014
  qla_target(0): Unable to send command to target, sending BUSY status

Such response causes command timeout on the initiator. Error handler thread
on the initiator will be spawned to abort the commands:

  scsi 23:0:0:0: tag#0 abort scheduled
  scsi 23:0:0:0: tag#0 aborting command
  qla2xxx [0000:af:00.0]-188c:23: Entered qla24xx_abort_command.
  qla2xxx [0000:af:00.0]-801c:23: Abort command issued nexus=23:0:0 -- 0 2003.

Command abort is rejected by target and fails (2003), error handler then
tries to perform DEVICE RESET and TARGET RESET but they're also doomed to
fail because TMFs are ignored for the deleted sessions.

Then initiator makes BUS RESET that resets the link via
qla2x00_full_login_lip(). BUS RESET succeeds and brings initiator port up,
SAN switch detects that and sends RSCN to the target port and it fails
again the same way as described above. It never goes out of the loop.

The change breaks the RSCN loop by keeping initiator sessions mentioned in
RSCN payload in all modes, including dual and pure target mode.

Link: https://lore.kernel.org/r/20200605144435.27023-1-r.bolshakov@yadro.com
Fixes: 2037ce49d30a ("scsi: qla2xxx: Fix stale session")
Cc: Quinn Tran <qutran@marvell.com>
Cc: Arun Easi <aeasi@marvell.com>
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Daniel Wagner <dwagner@suse.de>
Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: stable@vger.kernel.org # v5.4+
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Shyam Sundar <ssundar@marvell.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit 632f24f09d5b7c8a2f94932c3391ca957ae76cc4.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9125 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:20:49 +00:00
Bart Van Assche
0a2748f657 qla2x00t-32gbit: Set NVMe status code for failed NVMe FCP request 
The qla2xxx driver knows when request was processed successfully or
not. But it always sets the NVMe status code to 0/NVME_SC_SUCCESS. The
upper layer needs to figure out from the rcv_rsplen and transferred_length
variables if the request was transferred successfully. This is not always
possible, e.g. when the request data length is 0, the transferred_length is
also set 0 which is interpreted as success in nvme_fc_fcpio_done(). Let's
inform the upper layer (nvme_fc_fcpio_done()) when something went wrong.

nvme_fc_fcpio_done() maps all non-NVME_SC_SUCCESS status codes to
NVME_SC_HOST_PATH_ERROR. There isn't any benefit to map the QLA status code
to the NVMe status code. Therefore, use NVME_SC_INTERNAL to indicate an
error which aligns it with the lpfc driver.

Link: https://lore.kernel.org/r/20200604100745.89250-1-dwagner@suse.de
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

See also upstream commit ef2e3ec520a8c20661ca4e7d17a5c7110d3a7828.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9124 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 15:19:56 +00:00
Bart Van Assche
be6191fb92 debian: make scst-dkms provide scst 
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9123 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-29 03:17:06 +00:00
Bart Van Assche
15033c44c6 scst: Fix the RHEL 6 / 7 kernel_write() backport 
This patch unbreaks persistent reservation support.

Fixes: 94018a42e3 ("scst: Use kernel_{read,write}() instead of scst_{read,write}()")
Reported-by: Gleb Chesnokov <Chesnokov.G@raidix.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9121 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-28 04:16:28 +00:00
Bart Van Assche
d333ce8232 Restore the on_alua_state_change_*() callback functions 
Apparently the bind_alua_state functionality is being used. Hence restore
the on_alua_state_change_*() callback functions. The changes compared to
the previous implementation are:
* Only invoke the on_alua_state_change_*() callback functions if the state
  of a local target port group is being modified.
* Report information about ALUA callback activity with PRINT_INFO() instead
  of TRACE_MGMT_DBG().

This patch reverts commit 29548a4ad7 ("scst: Remove the
on_alua_state_change_*() callback functions").


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9120 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-10 00:31:42 +00:00
Bart Van Assche
e0c63c52e7 scst: Introduce the function __scst_tgt_set_state() 
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9119 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-10 00:29:09 +00:00
Bart Van Assche
6616eb6cf7 scst_copy_mgr: Suppress a Coverity taint complaint 
Suppress the following (false positive) Coverity complaint:

    CID 361193:  Insecure data handling  (TAINTED_SCALAR)
    Passing tainted variable "sense_len" to a tainted sink.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9118 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-09 00:42:32 +00:00
Bart Van Assche
41b4e25644 qla2x00t-32gbit: Always check the return value of qla24xx_get_isp_stats() 
This patch fixes the following Coverity warning:

    CID 361199 (#1 of 1): Unchecked return value (CHECKED_RETURN)
    3. check_return: Calling qla24xx_get_isp_stats without checking return
    value (as is done elsewhere 4 out of 5 times).


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9117 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-09 00:41:51 +00:00
Bart Van Assche
31dbbf3274 usr/fileio: Suppress a Coverity complaint about 'page_size' 
Suppress the following Coverity complaint:

    CID 361202:  Error handling issues  (NEGATIVE_RETURNS)
    "page_size" is passed to a parameter that cannot be negative.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9116 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-09 00:41:14 +00:00
Bart Van Assche
6138af9193 scst_pres: Fix a potential buffer overflow in tid_secure() 
This was detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9115 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-09 00:40:40 +00:00
Bart Van Assche
534f63f47b scst_pres: Use {get,put}_unaligned_be64() instead of {get,put}_unaligned_be() 
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9114 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-09 00:37:56 +00:00
Bart Van Assche
754f932d5d scst: Revert r9108 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9109 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-08 15:22:23 +00:00
Bart Van Assche
048ddfc638 scst_lib: Fix two lockdep_assert_held() statements 
Fixes: 628f3939bc ("scst: Rework SCSI pass-through support for kernel versions >= 2.6.30") # r5979.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9108 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-08 15:17:09 +00:00
Bart Van Assche
e05aab1c70 nightly build: Update kernel versions 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9106 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-03 03:48:51 +00:00
Bart Van Assche
f397c9558c Fix scst-dkms-rpm build for EL mainline kernels 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9105 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-03 03:39:01 +00:00
Bart Van Assche
f0214a59bb Fix rpm build for EL mainline kernels 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9104 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-03 03:38:01 +00:00
Bart Van Assche
2bafc3bd51 scst: Fix three potential integer overflows 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9103 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-03 03:29:33 +00:00
Bart Van Assche
0aed574e88 scripts/generate-kernel-patch: Make this script appropriate for the trunk and 3.4.x branches 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9098 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-03 02:56:37 +00:00
Bart Van Assche
c973152d8d qla2x00t, qla2x00t-32gbit: Remove unused code 
This was detected by the clang compiler.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9096 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-02 22:55:54 +00:00
Bart Van Assche
c22a2d11b1 iscsi-scst: Fix the CONFIG_IPV6=n build 
See also https://github.com/bvanassche/scst/issues/23.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9095 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-02 22:54:39 +00:00
Bart Van Assche
b1331f9a90 qla2x00t-32gbit: Fix the RHEL / CentOS 8.2 build 
This patch has been tested against kernel version 4.18.0-193.14.2.el8_2.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9094 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-02 21:54:29 +00:00
Bart Van Assche
3fd6a8c93c nightly build: Update kernel versions 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9093 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-02 21:53:42 +00:00
Bart Van Assche
ca607d88dd qla2x00t-32gbit: Change two fxdisc_entry_fx00 members from a scalar into an array 
This patch does not change any functionality but suppresses a Coverity
warning.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9092 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-02 21:53:19 +00:00
Bart Van Assche
757b42c2ba qla2x00t: Fix two buffer overflows 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9091 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-02 21:22:13 +00:00
Bart Van Assche
1b5e2eb482 isert-scst: Fail login if max_sge is too small 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9090 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-02 21:21:38 +00:00
Bart Van Assche
ecea60a694 Make it possible to build SCST with clang 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9089 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2020-08-02 21:19:24 +00:00