mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-12 19:02:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

dht: Use const reference for token_metadata arg

Browse Source 
Two places in dht code have token_metadata _value_ arguments, but only read
tokens from them. Optimize it a bit by turning values into const references.

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
Message-Id: <20200207112408.18352-1-xemul@scylladb.com>
This commit is contained in:
Pavel Emelyanov
2020-02-07 14:24:08 +03:00
committed by Avi Kivity
parent 5950a9e37f
commit 00746d6a16
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dht/boot_strapper.cc
View File

@@ -72,7 +72,7 @@ future<> boot_strapper::bootstrap() {
}
std::unordered_set<token> boot_strapper::get_bootstrap_tokens(token_metadata metadata, database& db) {
std::unordered_set<token> boot_strapper::get_bootstrap_tokens(const token_metadata& metadata, database& db) {
auto initial_tokens = db.get_initial_tokens();
// if user specified tokens, use those
if (initial_tokens.size() > 0) {
@@ -103,7 +103,7 @@ std::unordered_set<token> boot_strapper::get_bootstrap_tokens(token_metadata met
return tokens;
}
std::unordered_set<token> boot_strapper::get_random_tokens(token_metadata metadata, size_t num_tokens) {
std::unordered_set<token> boot_strapper::get_random_tokens(const token_metadata& metadata, size_t num_tokens) {
std::unordered_set<token> tokens;
while (tokens.size() < num_tokens) {
auto token = dht::token::get_random_token();

4
dht/boot_strapper.hh
View File

@@ -73,9 +73,9 @@ public:
* otherwise, if num_tokens == 1, pick a token to assume half the load of the most-loaded node.
* else choose num_tokens tokens at random
*/
static std::unordered_set<token> get_bootstrap_tokens(token_metadata metadata, database& db);
static std::unordered_set<token> get_bootstrap_tokens(const token_metadata& metadata, database& db);
static std::unordered_set<token> get_random_tokens(token_metadata metadata, size_t num_tokens);
static std::unordered_set<token> get_random_tokens(const token_metadata& metadata, size_t num_tokens);
#if 0
public static class StringSerializer implements IVersionedSerializer<String>
{