mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

replica/mutation_dump: create_underlying_mutation_sources(): remove false move

Browse Source 
transformed_cr is moved in a loop, in each iteration. This is harmless
because the variable is const and the move has no effect, yet it is
confusing to readers and triggers false positives in clang-tidy
(moved-from object reused). Remove it.

Fixes: #18322

Closes scylladb/scylladb#18348
This commit is contained in:
Botond Dénes
2024-04-22 10:40:28 -04:00
committed by Tomasz Grabiec
parent e9285e5c04
commit 275ed9a9bc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
replica/mutation_dump.cc
View File

@@ -184,7 +184,7 @@ private:
auto& e = prepared_mutation_sources[ms_it->first];
e.ms = ms_it->second;
maybe_push(e.region_intervals, region_int, std::compare_three_way{});
maybe_push(e.underlying_crs, std::move(transformed_cr), clustering_key_view::tri_compare(*_underlying_schema));
maybe_push(e.underlying_crs, transformed_cr, clustering_key_view::tri_compare(*_underlying_schema));
++ms_it;
}
}