mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-02-12 06:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

ProcessProposal comment fix

Browse Source
This commit is contained in:
William Banfield
2022-02-23 10:59:54 -05:00
parent 2bfc90c0cb
commit 2a49070299
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
internal/consensus/state.go
View File

@@ -1453,12 +1453,13 @@ func (cs *State) defaultDoPrevote(ctx context.Context, height int64, round int32
}
/*
Before prevoting on the block received from the proposer for the current round and height,
we request the Application, via `ProcessProposal` ABCI call, to confirm that the block is
valid. If the Application does not accept the block, Tendermint prevotes `nil`.
The block has now passed Tendermint's validation rules.
Before prevoting the block received from the proposer for the current round and height,
we request the Application, via the ProcessProposal, ABCI call to confirm that the block is
valid. If the Application does not accept the block, Tendermint prevotes nil.
WARNING: misuse of block rejection by the Application can seriously compromise Tendermint's
liveness properties. Please see `PrepareProposal`-`ProcessProposal` coherence and determinism
liveness properties. Please see PrepareProposal-ProcessProposal coherence and determinism
properties in the ABCI++ specification.
*/
isAppValid, err := cs.blockExec.ProcessProposal(ctx, cs.ProposalBlock, cs.state)