add todo for log line related to unmarshal in mconn receive

This commit is contained in:
William Banfield
2022-10-20 12:16:02 -04:00
parent 41df563982
commit ef17093bb4

View File

@@ -409,15 +409,19 @@ func createMConnection(
// which does onPeerError.
panic(fmt.Sprintf("Unknown channel %X", chID))
}
mt := msgTypeByChID[chID]
msg := proto.Clone(mt)
err := proto.Unmarshal(msgBytes, msg)
if err != nil {
// TODO(williambanfield) add a log line
return
}
labels := []string{
"peer_id", string(p.ID()),
"chID", fmt.Sprintf("%#x", chID),
}
p.metrics.PeerReceiveBytesTotal.With(labels...).Add(float64(len(msgBytes)))
p.metrics.MessageReceiveBytesTotal.With("message_type", "tmp").Add(float64(len(msgBytes)))
mt := msgTypeByChID[chID]
msg := proto.Clone(mt)
proto.Unmarshal(msgBytes, msg)
reactor.Receive(chID, p, msgBytes)
reactor.NewReceive(Envelope{
ChannelID: chID,