mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-09-05 07:37:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,182 Commits 530 Branches 244 Tags
thane/7655-vote-extensions
Commit Graph
10182 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
William Banfield f6b0707c9b add unit tests for vote extension methods 2022-04-15 10:20:19 -04:00
Thane ThomsonandGitHub ed7daa96af Merge branch 'master' into thane/7655-vote-extensions 2022-04-14 19:32:45 -04:00
M. J. FrombergerandGitHub 43f92806fd Update pending changelog for #8352. (#8354) 
I forgot to add this before merging. 🙁
 2022-04-14 23:07:59 +00:00
M. J. FrombergerandGitHub 34e727676c keymigrate: fix conversion of transaction hash keys (#8352) 
* keymigrate: fix conversion of transaction hash keys

In the legacy database format, keys were generally stored with a string prefix
to partition the key space. Transaction hashes, however, were not prefixed: The
hash of a transaction was the entire key for its record.

When the key migration script scans its input, it checks the format of each
key to determine whether it has already been converted, so that it is safe to run
the script over an already-converted database.

After checking for known prefixes, the migration script used two heuristics to
distinguish ABCI events and transaction hashes: For ABCI events, whose keys
used the form "name/value/height/index", it checked for the right number of
separators. For hashes, it checked that the length is exactly 32 bytes (the
length of a SHA-256 digest) AND that the value does not contain a "/".

This last check is problematic: Any hash containing the byte 0x2f (the code
point for "/") would be incorrectly filtered out from conversion. This leads to
some transaction hashes not being converted.

To fix this problem, this changes how the script recognizes keys:

1. Use a more rigorous syntactic check to filter out ABCI metadata.
2. Use only the length to identify hashes among what remains.

This change is still not a complete fix: It is possible, though unlikely, that
a valid hash could happen to look exactly like an ABCI metadata key. However,
the chance of that happening is vastly smaller than the chance of generating a
hash that contains at least one "/" byte.

Similarly, it is possible that an already-converted key of some other type
could be mistaken for a hash (not a converted hash, ironically, but another
type of the right length). Again, we can't do anything about that.
 2022-04-14 15:41:40 -07:00
Thane Thomson e4dd69118a e2e: add error logs when we get an unexpected height in ExtendVote or VerifyVoteExtension requests 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-14 17:40:53 -04:00
Thane ThomsonandGitHub 61899b2dab Merge branch 'master' into thane/7655-vote-extensions 2022-04-14 16:44:19 -04:00
Thane Thomson faec1d3c52 consensus: remove previously added test helper functionality 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-14 16:43:26 -04:00
Thane Thomson cb970564d7 consensus: fix flaky TestPrepareProposalReceivesVoteExtensions 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-14 16:41:08 -04:00
Thane Thomson c89890b111 proto/types: use fixed-length 64-bit integers for rounds in CanonicalVoteExtension 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-14 16:40:03 -04:00
dependabot[bot]andGitHub a0f51d0370 build(deps): Bump github.com/spf13/viper from 1.10.1 to 1.11.0 (#8344) 
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.10.1 to 1.11.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/spf13/viper/releases">github.com/spf13/viper's releases</a>.</em></p>
<blockquote>
<h2>v1.11.0</h2>

<h2>What's Changed</h2>
<h3>Exciting New Features 🎉</h3>
<ul>
<li>Experimental yaml v3 library support by <a href="https://github.com/sagikazarmark"><code>@​sagikazarmark</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1273">spf13/viper#1273</a></li>
<li>Experimental toml v2 support by <a href="https://github.com/sagikazarmark"><code>@​sagikazarmark</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1274">spf13/viper#1274</a></li>
<li>Experimental logger by <a href="https://github.com/sagikazarmark"><code>@​sagikazarmark</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1275">spf13/viper#1275</a></li>
</ul>
<h3>Enhancements 🚀</h3>
<ul>
<li>Remove unnecessary operand by <a href="https://github.com/steviebps"><code>@​steviebps</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1213">spf13/viper#1213</a></li>
<li>Improve encoding layer by <a href="https://github.com/sagikazarmark"><code>@​sagikazarmark</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1167">spf13/viper#1167</a></li>
<li>Allow merging configs with different types of leaf values by <a href="https://github.com/illarion"><code>@​illarion</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1181">spf13/viper#1181</a></li>
</ul>
<h3>Bug Fixes 🐛</h3>
<ul>
<li>Disable race detector on windows by <a href="https://github.com/sagikazarmark"><code>@​sagikazarmark</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1269">spf13/viper#1269</a></li>
</ul>
<h3>Breaking Changes 🛠</h3>
<ul>
<li>Drop Go 1.14 support by <a href="https://github.com/sagikazarmark"><code>@​sagikazarmark</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1327">spf13/viper#1327</a></li>
</ul>
<h3>Dependency Updates ⬆️</h3>
<ul>
<li>build(deps): bump github.com/spf13/afero from 1.6.0 to 1.7.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1265">spf13/viper#1265</a></li>
<li>build(deps): bump github.com/spf13/afero from 1.7.0 to 1.7.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1271">spf13/viper#1271</a></li>
<li>build(deps): bump github.com/spf13/afero from 1.7.1 to 1.8.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1281">spf13/viper#1281</a></li>
<li>build(deps): bump gopkg.in/ini.v1 from 1.66.2 to 1.66.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1287">spf13/viper#1287</a></li>
<li>build(deps): bump github.com/spf13/afero from 1.8.0 to 1.8.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1291">spf13/viper#1291</a></li>
<li>build(deps): bump actions/github-script from 5 to 6 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1295">spf13/viper#1295</a></li>
<li>build(deps): bump actions/checkout from 2 to 3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1304">spf13/viper#1304</a></li>
<li>build(deps): bump github.com/magiconair/properties from 1.8.5 to 1.8.6 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1299">spf13/viper#1299</a></li>
<li>build(deps): bump gopkg.in/ini.v1 from 1.66.3 to 1.66.4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1293">spf13/viper#1293</a></li>
<li>build(deps): bump github.com/spf13/afero from 1.8.1 to 1.8.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1311">spf13/viper#1311</a></li>
<li>build(deps): bump actions/setup-go from 2 to 3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1319">spf13/viper#1319</a></li>
<li>build(deps): bump github.com/pelletier/go-toml/v2 from 2.0.0-beta.6 to 2.0.0-beta.7 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1320">spf13/viper#1320</a></li>
<li>build(deps): bump github.com/pelletier/go-toml/v2 from 2.0.0-beta.7 to 2.0.0-beta.8 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1322">spf13/viper#1322</a></li>
<li>Update crypt by <a href="https://github.com/sagikazarmark"><code>@​sagikazarmark</code></a> in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1325">spf13/viper#1325</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/steviebps"><code>@​steviebps</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1213">spf13/viper#1213</a></li>
<li><a href="https://github.com/illarion"><code>@​illarion</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/spf13/viper/pull/1181">spf13/viper#1181</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/spf13/viper/compare/v1.10.1...v1.11.0">https://github.com/spf13/viper/compare/v1.10.1...v1.11.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/spf13/viper/commit/6986c0ab4883dda50b1eed5a8237bec3e0d3f5cd"><code>6986c0a</code></a> chore: update crypt</li>
<li><a href="https://github.com/spf13/viper/commit/65293ecec2f2d7237de9261f637c42d451f94a3d"><code>65293ec</code></a> add release note configuration</li>
<li><a href="https://github.com/spf13/viper/commit/6804da723f74ede77f830e4c755c52a8e9d6be84"><code>6804da7</code></a> chore!: drop Go 1.14 support</li>
<li><a href="https://github.com/spf13/viper/commit/5b21ca137d76e6a20ff0121127b87ab05d8c35c8"><code>5b21ca1</code></a> fix: deprecated config</li>
<li><a href="https://github.com/spf13/viper/commit/55fac1047e36ffc8c6664ce0ba6116e991371453"><code>55fac10</code></a> chore: fix lint</li>
<li><a href="https://github.com/spf13/viper/commit/e0bf4ac05da7bcdc88892a6776ab3e1b78bad558"><code>e0bf4ac</code></a> chore: add go 1.18 builds</li>
<li><a href="https://github.com/spf13/viper/commit/973c265115bf4e976bb30160129f5d033d316e41"><code>973c265</code></a> build(deps): bump github.com/pelletier/go-toml/v2</li>
<li><a href="https://github.com/spf13/viper/commit/129e4f973c4213fe1d28b59518706a540ea900bb"><code>129e4f9</code></a> build(deps): bump github.com/pelletier/go-toml/v2</li>
<li><a href="https://github.com/spf13/viper/commit/9a8603d8f8352543f9331cdef0b3a29b58627244"><code>9a8603d</code></a> build(deps): bump actions/setup-go from 2 to 3</li>
<li><a href="https://github.com/spf13/viper/commit/dc76f3c0a91b446606eaafc3e8ded86d24d2bfb3"><code>dc76f3c</code></a> build(deps): bump github.com/spf13/afero from 1.8.1 to 1.8.2</li>
<li>Additional commits viewable in <a href="https://github.com/spf13/viper/compare/v1.10.1...v1.11.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/spf13/viper&package-manager=go_modules&previous-version=1.10.1&new-version=1.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
 2022-04-14 15:40:00 +00:00
dependabot[bot]andGitHub be7cb50bb3 build(deps): Bump github.com/vektra/mockery/v2 from 2.10.4 to 2.10.6 (#8346) 
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.10.4 to 2.10.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vektra/mockery/releases">github.com/vektra/mockery/v2's releases</a>.</em></p>
<blockquote>
<h2>v2.10.6</h2>
<h2>Changelog</h2>
<ul>
<li>df6e689 Add PR/issue templates</li>
<li>e8bf201 Add golang-1.18 note</li>
<li>54589be Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/445">#445</a> from bigbluedisco/fix/bump-golang-org-x-tools</li>
<li>aa25af0 fix: bump golang.org/x/tools to v0.1.10 to fix some go 1.18 issues</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/vektra/mockery/commit/54589be6dd37d7ae95959995575f11931cf864c8"><code>54589be</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/445">#445</a> from bigbluedisco/fix/bump-golang-org-x-tools</li>
<li><a href="https://github.com/vektra/mockery/commit/aa25af0c7dab9b25794455ba66ad18ab202a546e"><code>aa25af0</code></a> fix: bump golang.org/x/tools to v0.1.10 to fix some go 1.18 issues</li>
<li><a href="https://github.com/vektra/mockery/commit/e8bf20167598ee4ebc67435c8ee3896218a354e6"><code>e8bf201</code></a> Add golang-1.18 note</li>
<li><a href="https://github.com/vektra/mockery/commit/df6e689d948adb8eb0ee4301fe945795defcd2d7"><code>df6e689</code></a> Add PR/issue templates</li>
<li>See full diff in <a href="https://github.com/vektra/mockery/compare/v2.10.4...v2.10.6">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/vektra/mockery/v2&package-manager=go_modules&previous-version=2.10.4&new-version=2.10.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
 2022-04-14 14:51:38 +00:00
M. J. FrombergerandGitHub 69874c2050 confix: convert tx-index.indexer from string to array (#8342) 
The format of this config value was changed in v0.35.

- Move plan to its own file (for ease of reading).
- Convert indexer string to an array if not already done.
 2022-04-14 06:20:49 -07:00
Callum WatersandGitHub 68c9efdb82 cli: simplify resetting commands (#8312) 2022-04-14 12:27:08 +12:00
Thane Thomson 77ac2b3c08 proto: update field description for vote extension sig in vote message 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 19:05:12 -04:00
Thane Thomson 68245d7348 proto: update field descriptions for vote message 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 19:05:12 -04:00
Thane ThomsonandGitHub a07ae242a5 Merge branch 'master' into thane/7655-vote-extensions 2022-04-13 19:05:05 -04:00
M. J. FrombergerandGitHub 6bbf5b6d0f Work around markdown-link-check issues. (#8339) 
Work around two issues causing the markdown link check to fail in CI.

1. https://github.com/actions/checkout/pull/760. A git permissions issue,
   apparently triggered by a combination of a git change and the behaviour of
   actions/checkout.

2. https://github.com/gaurav-nelson/github-action-markdown-link-check/pull/129.
   Merging an updated version of the underlying package that fixes a bug in the
   handling of local #anchors.

The workaround is a temporary patched fork of the link-checker action.  This
should be removed once the upstream issues are addressed.
 2022-04-13 16:01:39 -07:00
Thane Thomson 8b104e456b privval: update signing logic to cater for vote extensions 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 18:49:47 -04:00
M. J. FrombergerandGitHub 024f6117ee confix: remove mempool.version in v0.36 (#8334) 2022-04-13 13:41:35 -07:00
M. J. FrombergerandGitHub 9296717433 Update RFC ToC for RFC-015. (#8338) 2022-04-13 20:25:59 +00:00
M. J. FrombergerandGitHub 6dc15b2f50 Only run the markdown linter if markdown was touched. (#8337) 2022-04-13 13:13:59 -07:00
Sam KleinmanandGitHub 0e4b18806e pubsub: [minor] remove unused stub method (#8316) 
OnReset was removed from the service interface and we missed deleting
this.
 2022-04-13 19:20:56 +00:00
Sam KleinmanandGitHub c45367e22c rpc: avoid leaking threads (#8328) 2022-04-13 14:09:49 -04:00
Thane Thomson d2d87485ca Merge latest changes from master 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 14:00:40 -04:00
Thane Thomson 43f4f5ca99 privval: change test vote type to precommit since we use an extension 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 13:57:38 -04:00
Thane Thomson b3b74dfa3a Remove unnecessary address parameter from CanonicalVoteExtension 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 13:50:48 -04:00
Thane Thomson 8104cf5188 types: remove extraneous call to voteWithoutExtension in test 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 13:33:32 -04:00
Thane Thomson 298a6b27ad e2e: reject vote extensions if the request height does not match what we expect 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 13:31:37 -04:00
Thane Thomson c420dd4507 Add TODO to always require extension signatures in vote validation 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 13:09:16 -04:00
Thane Thomson 532a0f9719 Remove channel capacity constraint in test helper to avoid missing messages 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-13 13:01:49 -04:00
M. J. FrombergerandGitHub 29ad4dcb3b Remove resolved TODO comments. (#8325) 
Resolved by merge of #8300.
 2022-04-13 04:44:16 +00:00
Sam KleinmanandGitHub 80b8c0057b state: remove unused weighted time (#8315) 2022-04-12 21:14:00 +00:00
Sam KleinmanandGitHub 5d4d01b4e4 service: minor cleanup of comments (#8314) 2022-04-12 17:11:21 -04:00
Sam KleinmanandGitHub 571d26fbb0 events: remove unused event code (#8313) 2022-04-12 14:58:14 -04:00
Thane Thomson 35aa879c7e Only set vote extension signatures when signing is successful 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-12 13:53:32 -04:00
Thane Thomson b054c42b03 e2e: check that our added tx does not cause all txs to exceed req.MaxTxBytes 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-12 13:49:33 -04:00
Thane Thomson 50fc899afe Perform additional check in ProcessProposal for special txs generated by vote extensions 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-12 12:49:13 -04:00
Thane Thomson 5884ce5132 Revert BlockIDFlag parameter in node test 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-12 12:14:28 -04:00
Thane Thomson 8bb7983c4c Read lock consensus state mutex in test helper to avoid data race 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-11 21:08:30 -04:00
Thane Thomson 550216249c Merge from master and fix conflicts 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-11 20:39:53 -04:00
Thane Thomson e7523c430a Allow for selective subscription by vote type 
This is an attempt to fix the intermittently failing
`TestPrepareProposalReceivesVoteExtensions` test in the internal
consensus package.

Occasionally we get prevote messages via the subscription channel, and
we're not interested in those. This change allows us to specify what
types of votes we're interested in (i.e. precommits) and discard the
rest.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-11 20:35:45 -04:00
Thane Thomson 3124ac5c72 Expand on vote matching error messages in testing 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
 2022-04-11 20:05:19 -04:00
M. J. FrombergerandGitHub cf337cc3f2 Add configuration updates for Tendermint v0.36. (#8310) 
* v36: remove [fastsync] and [blocksync] config sections
* v36: remove [blocksync], consolidate rename
* v36: remove gRPC options from [rpc]
* v36: add top-level mode setting
* v36: remove deprecated per-node consensus timeouts
* v36: remove vestigial mempool.wal-dir setting
* v36: add queue-type setting
* v36: add p2p connection limits
* v36: add or update statsync.fetchers
* v36: add statesync.use-p2p setting
 2022-04-11 14:49:17 -07:00
William BanfieldandGitHub 969690d81c abci++: only include meaningful header fields in data passed-through to application (#8216) 
closes: #7950
 2022-04-11 20:27:50 +00:00
M. J. FrombergerandGitHub 9ec30ecc0c Add configuration diff tool. (#8298) 
* Add diff outputs as testdata.
* Normalize all samples to kebabs.
 2022-04-11 12:41:27 -07:00
Thane ThomsonandGitHub af6d500068 Merge branch 'master' into thane/7655-vote-extensions 2022-04-11 10:53:50 -04:00
Ismail KhoffiandGitHub 0e32ad9e5c Update outdated doc comment (#8309) 
SetEventBus was deleted, same with the NopEventBus
 2022-04-11 07:06:57 -07:00
Callum WatersandGitHub b7e87eef05 cli: add graceful catches to SIGINT (#8308) 2022-04-12 01:20:43 +12:00
dependabot[bot]andGitHub 0ab2f31239 build(deps): Bump github.com/creachadair/tomledit from 0.0.11 to 0.0.13 (#8307) 
Bumps [github.com/creachadair/tomledit](https://github.com/creachadair/tomledit) from 0.0.11 to 0.0.13.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/creachadair/tomledit/commit/baee445826f2d7eed5cda4c7349e4a8cc9d625d4"><code>baee445</code></a> Release v0.0.13.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/8dfcc1b37841ba1f5f2173540f523f577980f454"><code>8dfcc1b</code></a> Exercise insertion before comments.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/97f4e85ccf5af8f62b3ba33a7a792772d7beb8b6"><code>97f4e85</code></a> When inserting a key, push it before block comments.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/029089e31180da4298205c5e6aab1f1dfa526d96"><code>029089e</code></a> Release v0.0.12.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/d226405c2afce3e8c416970751c9fdad7a273830"><code>d226405</code></a> Test finding the global table.</li>
<li><a href="https://github.com/creachadair/tomledit/commit/34b7aad990bfe0b6c9fde5433ee8b430ed63ae72"><code>34b7aad</code></a> Let FindTable return the global table with an empty name.</li>
<li>See full diff in <a href="https://github.com/creachadair/tomledit/compare/v0.0.11...v0.0.13">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/creachadair/tomledit&package-manager=go_modules&previous-version=0.0.11&new-version=0.0.13)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
 2022-04-11 12:47:05 +00:00
dependabot[bot]andGitHub 9a46f575f5 build(deps): Bump actions/upload-artifact from 2 to 3 (#8303) 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update default runtime to node16 (<a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/293">#293</a>)</li>
<li>Update package-lock.json file version to 2 (<a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/302">#302</a>)</li>
</ul>
<h3>Breaking Changes</h3>
<p>With the update to Node 16, all scripts will now be run with Node 16 rather than Node 12.</p>
<h2>v2.3.1</h2>
<p>Fix for empty fails on Windows failing on upload <a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/281">#281</a></p>
<h2>v2.3.0 Upload Artifact</h2>
<ul>
<li>Optimizations for faster uploads of larger files that are already compressed</li>
<li>Significantly improved logging when there are chunked uploads</li>
<li>Clarifications in logs around the upload size and prohibited characters that aren't allowed in the artifact name or any uploaded files</li>
<li>Various other small bugfixes &amp; optimizations</li>
</ul>
<h2>v2.2.4</h2>
<ul>
<li>Retry on HTTP 500 responses from the service</li>
</ul>
<h2>v2.2.3</h2>
<ul>
<li>Fixes for proxy related issues</li>
</ul>
<h2>v2.2.2</h2>
<ul>
<li>Improved retryability and error handling</li>
</ul>
<h2>v2.2.1</h2>
<ul>
<li>Update used actions/core package to the latest version</li>
</ul>
<h2>v2.2.0</h2>
<ul>
<li>Support for artifact retention</li>
</ul>
<h2>v2.1.4</h2>
<ul>
<li>Add Third Party License Information</li>
</ul>
<h2>v2.1.3</h2>
<ul>
<li>Use updated version of the <code>@action/artifact</code> NPM package</li>
</ul>
<h2>v2.1.2</h2>
<ul>
<li>Increase upload chunk size from 4MB to 8MB</li>
<li>Detect case insensitive file uploads</li>
</ul>
<h2>v2.1.1</h2>
<ul>
<li>Fix for certain symlinks not correctly being identified as directories before starting uploads</li>
</ul>
<h2>v2.1.0</h2>
<ul>
<li>Support for uploading artifacts with multiple paths</li>
<li>Support for using exclude paths</li>
<li>Updates to dependencies</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/upload-artifact/commit/6673cd052c4cd6fcf4b4e6e60ea986c889389535"><code>6673cd0</code></a> Update <code>lockfileVersion</code> in <code>package-lock.json</code> (<a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/302">#302</a>)</li>
<li><a href="https://github.com/actions/upload-artifact/commit/2244c8200304ec9588bf9399eac622d9fadc28c4"><code>2244c82</code></a> Update to node16 (<a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/293">#293</a>)</li>
<li><a href="https://github.com/actions/upload-artifact/commit/87348cee5fefa95e42e9b4804b4d68e130304158"><code>87348ce</code></a> Add 503 warning when uploading to the same artifact</li>
<li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/v2...v3">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=2&new-version=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
 2022-04-11 12:33:01 +00:00