Commit Graph

9532 Commits

Author SHA1 Message Date
Sam Kleinman
2c074e24e6 rfc: p2p light client (#7672) 2022-01-31 12:45:58 -05:00
Sam Kleinman
1d3ecf37ee consensus: remove unused closer construct (#7734)
This is clearly a cob-web in the code, and may predict a solution to #7729, though this is difficult to backport because we don't have contexts in 0.35
2022-01-31 16:03:20 +00:00
Sam Kleinman
2f1e08e948 conensus: put timeouts on reactor tests (#7733) 2022-01-31 15:04:56 +00:00
Sam Kleinman
a4e2f05d7a cmd: avoid package state in cli constructors (#7719) 2022-01-31 09:52:30 -05:00
M. J. Fromberger
95158636cd rpc: clean up unmarshaling of batch-valued responses (#7728)
Update the interface of the batch decoder to match the type signature of the
single-response case. The caller provides the outputs, so there is no need to
return them as well.

No functional changes.
2022-01-31 06:16:10 -08:00
dependabot[bot]
89194a61a4 build(deps): Bump github.com/prometheus/client_golang from 1.12.0 to 1.12.1 (#7732)
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.12.0 to 1.12.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/prometheus/client_golang/releases">github.com/prometheus/client_golang's releases</a>.</em></p>
<blockquote>
<h2>1.12.1 / 2022-01-29</h2>
<ul>
<li>[BUGFIX] Make the Go 1.17 collector concurrency-safe <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/969">#969</a>
<ul>
<li>Use simpler locking in the Go 1.17 collector <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/975">#975</a></li>
</ul>
</li>
<li>[BUGFIX] Reduce granularity of histogram buckets for Go 1.17 collector <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/974">#974</a></li>
<li>[ENHANCEMENT] API client: make HTTP reads more efficient <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/976">#976</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/prometheus/client_golang/compare/v1.12.0...v1.12.1">https://github.com/prometheus/client_golang/compare/v1.12.0...v1.12.1</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md">github.com/prometheus/client_golang's changelog</a>.</em></p>
<blockquote>
<h2>1.12.1 / 2022-01-29</h2>
<ul>
<li>[BUGFIX] Make the Go 1.17 collector concurrency-safe <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/969">#969</a>
<ul>
<li>Use simpler locking in the Go 1.17 collector <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/975">#975</a></li>
</ul>
</li>
<li>[BUGFIX] Reduce granularity of histogram buckets for Go 1.17 collector <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/974">#974</a></li>
<li>[ENHANCEMENT] API client: make HTTP reads more efficient <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/976">#976</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="2e1c4818cc"><code>2e1c481</code></a> Cut v1.12.1 (<a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/978">#978</a>)</li>
<li><a href="77626d64fa"><code>77626d6</code></a> Reduce granularity of histogram buckets for Go 1.17 collector (<a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/974">#974</a>)</li>
<li><a href="4dd3cbb4ab"><code>4dd3cbb</code></a> API client: make http reads more efficient (<a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/976">#976</a>)</li>
<li><a href="85206714ae"><code>8520671</code></a> Use simpler locking in the Go 1.17 collector (<a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/975">#975</a>)</li>
<li><a href="f63e219e6b"><code>f63e219</code></a> Make the Go 1.17 collector thread-safe (<a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/969">#969</a>)</li>
<li>See full diff in <a href="https://github.com/prometheus/client_golang/compare/v1.12.0...v1.12.1">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/prometheus/client_golang&package-manager=go_modules&previous-version=1.12.0&new-version=1.12.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
2022-01-31 09:34:25 +00:00
M. J. Fromberger
b3c85b795a docs: fix some typos in ADR 075. (#7726)
* docs: fix some typos in ADR 075.

* fix typo typo
2022-01-31 09:14:42 +00:00
M. J. Fromberger
fbe86ea645 rpc: simplify and consolidate response construction (#7725)
Responses are constructed from requests using MakeResponse, MakeError, and
MakeErrorf. This ensures the response is always paired with the correct ID,
makes cases where there is no ID more explicit at the usage site, and
consolidates the handling of error introspection across transports.

The logic for unpacking errors and assigning JSON-RPC response types was
previously duplicated in three places. Consolidate it in the types package for
the RPC subsystem.

* update test cases
2022-01-28 13:33:02 -08:00
M. J. Fromberger
20886fdb39 rpc: clean up encoding of request and response messages (#7721)
Instead of having the exported Request and Response type expose the version
directly, delegate version injection to an unexported shim.  We already had the
shim; this just boosts it to the top level and does a bit more checking.

* Check JSON-RPC version marker.
2022-01-28 11:41:23 -08:00
M. J. Fromberger
6f6935a44b rpc: don't route websocket-only methods on GET requests (#7715) 2022-01-27 14:52:41 -08:00
Sam Kleinman
6822378334 mempool: return duplicate tx errors more consistently (#7714) 2022-01-27 16:44:07 -05:00
Alexander Shcherbakov
9b32346ebd light: Fix absence proof verification by light client (#7639)
- use the full key path to pass to the VerifyAbsence function
2022-01-27 22:30:19 +01:00
M. J. Fromberger
557d86316b rpc: clean up unused non-default websocket client options (#7713)
These are only ever used with the defaults, except in our own tests.  A search
of cs.github.com shows no other callers.

The use in the test was solely to bug out the go-metrics package so its
goroutines don't trigger the leak checker. Use the package's own flag for that
purpose instead. Note that calling "Stop" on the metric helps, but is not
sufficient -- the Stop does not wait for its goroutine to exit.
2022-01-27 11:49:08 -08:00
M. J. Fromberger
e87d40719d rpc: remove unused websocket options (#7712)
These options are never set to anything but the defaults, so drop the options
and inline the defaults.
2022-01-27 10:15:56 -08:00
William Banfield
bd8726c784 Use proposer timestamp instead of genesis time for height 1 block time (#7711)
Merged to pbts branch in #7541
2022-01-27 17:04:55 +00:00
mempirate
db3044ff3c rpc: add application info to status call (#7701)
* rpc/coretypes: add `ApplicationInfo` to `ResultStatus`
* internal/rpc/core: return application version

Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com>
2022-01-27 07:24:01 -08:00
William Banfield
04bcfecce2 metrics: add metric for proposal timestamp difference (#7709)
Moving this over from the proposer-based timestamps branch #7550.
2022-01-27 14:42:56 +00:00
M. J. Fromberger
5eb50a43b5 ci: fix super-linter configuration settings (#7708)
- Revert the version pin from #7706.
- Override the YAML linter config to be more forgiving.
- Update YAML lint warnings in a number of files.

The choice of which lints to fix and which to override was ad hoc: I fixed the ones that were mainly whitespace oriented, and suppressed the ones that were document-structure related.

Fixes #7707.
2022-01-27 05:33:11 -08:00
M. J. Fromberger
1ac58469f3 Forward-port v0.35.1 changelogs. (#7705)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-01-26 20:40:23 +00:00
William Banfield
b37c10c324 params: increase default synchrony params (#7704) 2022-01-26 15:29:54 -05:00
M. J. Fromberger
09c41dc06d Pin super-linter to a less noisy version. (#7706)
The latest point release includes https://github.com/github/super-linter/pull/2295
which enables a bunch of checks that break existing use.
2022-01-26 11:57:44 -08:00
William Banfield
61f3aa0848 consensus: use buffered channel in TestStateFullRound1 (#7668) 2022-01-26 14:50:31 -05:00
dependabot[bot]
7fbad97e69 build(deps): Bump google.golang.org/grpc from 1.43.0 to 1.44.0 (#7695)
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.43.0 to 1.44.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.43.0...v1.44.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sam Kleinman <garen@tychoish.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
2022-01-26 09:26:40 -08:00
JayT106
2c9dec53a8 remove duplicate ABCIVersion (#7703) 2022-01-26 09:12:00 -08:00
M. J. Fromberger
05d8a0bd05 Mark ADR 075 as "accepted". (#7699) 2022-01-26 08:33:13 -08:00
William Banfield
0aa3b0b6fc Proposer-Based Timestamps Merge (#7605)
This pull request merges in the changes for implementing Proposer-based timestamps into `master`. The power was primarily being done in the `wb/proposer-based-timestamps` branch, with changes being merged into that branch during development. This pull request represents an amalgamation of the changes made into that development branch. All of the changes that were placed into that branch have been cleanly rebased on top of the latest `master`. The changes compile and the tests pass insofar as our tests in general pass.

### Note To Reviewers
 These changes have been extensively reviewed during development. There is not much new here. In the interest of making effective use of time, I would recommend against trying to perform a complete audit of the changes presented and instead examine for mistakes that may have occurred during the process of rebasing the changes. I gave the complete change set a first pass for any issues, but additional eyes would be very appreciated. 

In sum, this change set does the following:
closes #6942 
merges in #6849
2022-01-26 16:00:23 +00:00
M. J. Fromberger
441ecbaeec types: rename and extend the EventData interface (#7687)
This is the interface shared by types that can be used as event data in, for
example, subscriptions via the RPC.

To be compatible with the RPC service, data need to support JSON encoding.
Require this as part of the interface.
2022-01-26 07:01:55 -08:00
M. J. Fromberger
fcfe157f6b Remove unused xsalsa20symmetric package. (#7691)
This package has no uses within Tendermint core.
PR https://github.com/cosmos/cosmos-sdk/pull/11027 replaces the use in
the Cosmos SDK.

A follow-up to #7689 and #7690.
2022-01-26 06:23:20 -08:00
M. J. Fromberger
f64d64a7b5 ADR 074: RPC Event Subscription Interface (#7677)
Status: Proposed.
2022-01-26 06:19:32 -08:00
dependabot[bot]
b920cd4c32 build(deps): Bump github.com/golangci/golangci-lint from 1.43.0 to 1.44.0 (#7692)
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.43.0 to 1.44.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/releases">github.com/golangci/golangci-lint's releases</a>.</em></p>
<blockquote>
<h2>v1.44.0</h2>
<h2>Changelog</h2>
<ul>
<li>32cf48ed Add &quot;grouper&quot; linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2497">#2497</a>)</li>
<li>63f150ea Add decorder linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2453">#2453</a>)</li>
<li>55358972 Add errchkjson linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2362">#2362</a>)</li>
<li>e3d0247e Add maintidx linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2435">#2435</a>)</li>
<li>d2093896 Add support for multiple outputs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2386">#2386</a>)</li>
<li>efb35995 Bump github.com/ashanbrown/forbidigo from 1.2.0 to 1.3.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2487">#2487</a>)</li>
<li>6e2e51d8 Bump makezero to v1.1.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2490">#2490</a>)</li>
<li>e788757b Ensure that the Issues key in JSON format is a list (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2358">#2358</a>)</li>
<li>eaed228d Print error text in  tag content for more readable junit report (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2460">#2460</a>)</li>
<li>b5d8e698 Return error if any linter fails to run (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2471">#2471</a>)</li>
<li>ec58c481 Show deprecated mark in the CLI linters help (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2350">#2350</a>)</li>
<li>68f530a8 add containedctx linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2382">#2382</a>)</li>
<li>c53eb78a asciicheck: bump to v0.1.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2510">#2510</a>)</li>
<li>ae537189 bodyclose: bump to HEAD (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2508">#2508</a>)</li>
<li>ba3453d2 build(deps): bump actions/cache from 2.1.6 to 2.1.7 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2383">#2383</a>)</li>
<li>80659f85 build(deps): bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2491">#2491</a>)</li>
<li>8bc95624 build(deps): bump github.com/breml/bidichk from 0.2.0 to 0.2.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2354">#2354</a>)</li>
<li>f311ffd2 build(deps): bump github.com/breml/errchkjson from 0.2.0 to 0.2.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2493">#2493</a>)</li>
<li>ec2820c5 build(deps): bump github.com/esimonov/ifshort from 1.0.3 to 1.0.4 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2436">#2436</a>)</li>
<li>83962f47 build(deps): bump github.com/fzipp/gocyclo from 0.3.1 to 0.4.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2425">#2425</a>)</li>
<li>6ddb9071 build(deps): bump github.com/go-critic/go-critic from 0.6.1 to 0.6.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2474">#2474</a>)</li>
<li>a79803fa build(deps): bump github.com/kulti/thelper from 0.4.0 to 0.5.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2492">#2492</a>)</li>
<li>9e129498 build(deps): bump github.com/ldez/tagliatelle from 0.2.0 to 0.3.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2454">#2454</a>)</li>
<li>0ac5d371 build(deps): bump github.com/mattn/go-colorable from 0.1.11 to 0.1.12 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2384">#2384</a>)</li>
<li>620bd9bb build(deps): bump github.com/mgechev/revive from 1.1.2 to 1.1.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2517">#2517</a>)</li>
<li>ecbb9c47 build(deps): bump github.com/nishanths/exhaustive from 0.3.6 to 0.6.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2353">#2353</a>)</li>
<li>fc888cf0 build(deps): bump github.com/nishanths/exhaustive from 0.6.0 to 0.7.11 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2371">#2371</a>)</li>
<li>88d3ec0f build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2455">#2455</a>)</li>
<li>131ab76b build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2472">#2472</a>)</li>
<li>441d8443 build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2519">#2519</a>)</li>
<li>7d5bc8f0 build(deps): bump github.com/securego/gosec/v2 from 2.9.1 to 2.9.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2372">#2372</a>)</li>
<li>d0aead44 build(deps): bump github.com/securego/gosec/v2 from 2.9.2 to 2.9.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2385">#2385</a>)</li>
<li>56f27d0a build(deps): bump github.com/securego/gosec/v2 from 2.9.3 to 2.9.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2413">#2413</a>)</li>
<li>9bad615c build(deps): bump github.com/securego/gosec/v2 from 2.9.5 to 2.9.6 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2516">#2516</a>)</li>
<li>d29d9f12 build(deps): bump github.com/shirou/gopsutil/v3 from 3.21.10 to 3.21.11 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2405">#2405</a>)</li>
<li>b4a3bd8c build(deps): bump github.com/shirou/gopsutil/v3 from 3.21.11 to 3.21.12 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2456">#2456</a>)</li>
<li>ca8cd60f build(deps): bump github.com/spf13/cobra from 1.2.1 to 1.3.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2426">#2426</a>)</li>
<li>4ca6a2fc build(deps): bump github.com/spf13/viper from 1.10.0 to 1.10.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2424">#2424</a>)</li>
<li>f960879b build(deps): bump github.com/spf13/viper from 1.9.0 to 1.10.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2412">#2412</a>)</li>
<li>018befd3 build(deps): bump github.com/tommy-muehle/go-mnd/v2 from 2.4.0 to 2.5.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2518">#2518</a>)</li>
<li>8cdecc96 build(deps): bump gitlab.com/bosi/decorder from 0.2.0 to 0.2.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2473">#2473</a>)</li>
<li>4119132f build(deps): bump honnef.co/go/tools from 0.2.1 to 0.2.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2370">#2370</a>)</li>
<li>b845512b build(deps): bump mvdan.cc/gofumpt from 0.1.1 to 0.2.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2373">#2373</a>)</li>
<li>107b8307 build(deps): bump mvdan.cc/gofumpt from 0.2.0 to 0.2.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2427">#2427</a>)</li>
<li>49501691 bump bidichk from v0.1.1 to v0.2.0</li>
<li>a471733b bump github.com/yeya24/promlinter from v0.1.0 to HEAD (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2500">#2500</a>)</li>
<li>7f25fee1 bump varnamelen from v0.4.0 to v0.5.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2369">#2369</a>)</li>
<li>1b535204 bump varnamelen to v0.4.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2348">#2348</a>)</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md">github.com/golangci/golangci-lint's changelog</a>.</em></p>
<blockquote>
<h3>v1.44.0</h3>
<ol>
<li>new linters:
<ul>
<li><code>containedctx</code>: <a href="https://github.com/sivchari/containedctx">https://github.com/sivchari/containedctx</a></li>
<li><code>decorder</code>: <a href="https://gitlab.com/bosi/decorder">https://gitlab.com/bosi/decorder</a></li>
<li><code>errchkjson</code>: <a href="https://github.com/breml/errchkjson">https://github.com/breml/errchkjson</a></li>
<li><code>maintidx</code>: <a href="https://github.com/yagipy/maintidx">https://github.com/yagipy/maintidx</a></li>
<li><code>grouper</code>: <a href="https://github.com/leonklingele/grouper">https://github.com/leonklingele/grouper</a></li>
</ul>
</li>
<li>updated linters:
<ul>
<li><code>asciicheck</code>: bump to v0.1.1</li>
<li><code>bidichk</code>: from 0.1.1 to 0.2.1</li>
<li><code>bodyclose</code>: bump to HEAD</li>
<li><code>decorder</code>: from 0.2.0 to 0.2.1</li>
<li><code>depguard</code>: from 1.0.1 to 1.1.0</li>
<li><code>errchkjson</code>: from 0.2.0 to 0.2.1</li>
<li><code>errorlint</code>: bump to HEAD</li>
<li><code>exhaustive</code>: drop deprecated/unused settings</li>
<li><code>exhaustive</code>: from v0.2.3 to 0.7.11</li>
<li><code>forbidigo</code>: from 1.2.0 to 1.3.0</li>
<li><code>forcetypeassert</code>: bump to v0.1.0</li>
<li><code>gocritic</code>: from 0.6.1 to 0.6.2</li>
<li><code>gocritic</code>: support autofix</li>
<li><code>gocyclo</code>: from 0.3.1 to 0.4.0</li>
<li><code>godot</code>: add period option</li>
<li><code>gofumpt</code>: from 0.1.1 to 0.2.1</li>
<li><code>gomnd</code>: from 2.4.0 to 2.5.0</li>
<li><code>gomnd</code>: new configuration</li>
<li><code>gosec</code>: from 2.9.1 to 2.9.6</li>
<li><code>ifshort</code>: from 1.0.3 to 1.0.4</li>
<li><code>ineffassign</code>: bump to HEAD</li>
<li><code>makezero</code>: to v1.1.0</li>
<li><code>promlinter</code>: from v0.1.0 to HEAD</li>
<li><code>revive</code>: fix <code>enableAllRules</code></li>
<li><code>revive</code>: from 1.1.2 to 1.1.3</li>
<li><code>staticcheck</code>: from 0.2.1 to 0.2.2</li>
<li><code>tagliatelle</code>: from 0.2.0 to 0.3.0</li>
<li><code>thelper</code>: from 0.4.0 to 0.5.0</li>
<li><code>unparam</code>: bump to HEAD</li>
<li><code>varnamelen</code>: bump to v0.5.0</li>
<li><code>wrapcheck</code>: update configuration to include <code>ignoreSignRegexps</code></li>
</ul>
</li>
<li>documentation:
<ul>
<li>linters: improve pages about configuration</li>
<li>improve page about false-positive</li>
<li><code>nolintlint</code>: fix wrong default value in comment</li>
<li><code>revive</code>: add a more detailed configuration</li>
</ul>
</li>
<li>misc:
<ul>
<li>outputs: Add support for multiple outputs</li>
<li>outputs: Print error text in <code>&lt;failure&gt;</code> tag content for more readable JUnit output</li>
<li>outputs: ensure that the Issues key in JSON format is a list</li>
<li>Return error if any linter fails to run</li>
</ul>
</li>
</ol>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="617470fa9e"><code>617470f</code></a> docs(revive): fix typo on the option <code>disabled</code>(<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2520">#2520</a>)</li>
<li><a href="32cf48edc9"><code>32cf48e</code></a> Add &quot;grouper&quot; linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2497">#2497</a>)</li>
<li><a href="620bd9bb3d"><code>620bd9b</code></a> build(deps): bump github.com/mgechev/revive from 1.1.2 to 1.1.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2517">#2517</a>)</li>
<li><a href="9bad615c90"><code>9bad615</code></a> build(deps): bump github.com/securego/gosec/v2 from 2.9.5 to 2.9.6 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2516">#2516</a>)</li>
<li><a href="441d84436d"><code>441d844</code></a> build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2519">#2519</a>)</li>
<li><a href="018befd392"><code>018befd</code></a> build(deps): bump github.com/tommy-muehle/go-mnd/v2 from 2.4.0 to 2.5.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2518">#2518</a>)</li>
<li><a href="1b53352339"><code>1b53352</code></a> docs: improve configuration documentation (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2514">#2514</a>)</li>
<li><a href="44474a103e"><code>44474a1</code></a> forcetypeassert: bump to v0.1.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2511">#2511</a>)</li>
<li><a href="c53eb78ae1"><code>c53eb78</code></a> asciicheck: bump to v0.1.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2510">#2510</a>)</li>
<li><a href="171b3caef4"><code>171b3ca</code></a> ineffassign: bump to HEAD (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2509">#2509</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint/compare/v1.43.0...v1.44.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/golangci/golangci-lint&package-manager=go_modules&previous-version=1.43.0&new-version=1.44.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
2022-01-26 14:05:21 +00:00
M. J. Fromberger
51ffb95775 Remove unused chacha20poly1305 package. (#7690)
Fixes #7689.
2022-01-26 05:44:24 -08:00
M. J. Fromberger
079c7af007 pubsub: use concrete queries instead of an interface (#7686)
Remove the pubsub.Query interface and instead use the concrete query type.
Nothing uses any other implementation but pubsub/query.

* query: remove the error from the Matches method
* Update all usage.
2022-01-25 11:16:48 -08:00
Sam Kleinman
f163acf499 clist: reduce size of test workload for clist implementation (#7682) 2022-01-25 13:48:24 -05:00
Sam Kleinman
6a02714814 rpc: check error code for broadcast_tx_commit (#7683) 2022-01-25 13:35:03 -05:00
dependabot[bot]
5db7a7d6db build(deps): Bump github.com/vektra/mockery/v2 from 2.9.4 to 2.10.0 (#7685)
Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.9.4 to 2.10.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vektra/mockery/releases">github.com/vektra/mockery/v2's releases</a>.</em></p>
<blockquote>
<h2>v2.10.0</h2>
<h2>Changelog</h2>
<ul>
<li>95b8d4d Add mock generation with expecter</li>
<li>e5889c6 Merge branch 'master' into gejo-expecter-support</li>
<li>66d6564 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/396">#396</a> from Gevrai/gejo-expecter-support</li>
<li>b702d89 Update README.md</li>
</ul>
<h2>v2.9.5</h2>
<h2>Changelog</h2>
<ul>
<li>ff24d35 Adding more dependencies</li>
<li>5626edf Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/427">#427</a> from vektra/update_deps</li>
<li>21d2728 Upgrade all dependencies</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="66d6564919"><code>66d6564</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/396">#396</a> from Gevrai/gejo-expecter-support</li>
<li><a href="e5889c659c"><code>e5889c6</code></a> Merge branch 'master' into gejo-expecter-support</li>
<li><a href="b702d895c7"><code>b702d89</code></a> Update README.md</li>
<li><a href="5626edfab2"><code>5626edf</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/427">#427</a> from vektra/update_deps</li>
<li><a href="ff24d35774"><code>ff24d35</code></a> Adding more dependencies</li>
<li><a href="21d2728377"><code>21d2728</code></a> Upgrade all dependencies</li>
<li><a href="95b8d4d7f0"><code>95b8d4d</code></a> Add mock generation with expecter</li>
<li>See full diff in <a href="https://github.com/vektra/mockery/compare/v2.9.4...v2.10.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/vektra/mockery/v2&package-manager=go_modules&previous-version=2.9.4&new-version=2.10.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
2022-01-25 13:47:49 +00:00
Sam Kleinman
2c90a86a27 tests: reduce timeout to 4m from 8m (#7681) 2022-01-24 17:47:53 -05:00
M. J. Fromberger
7878ca6a8a Delete the custom libs/json (tmjson) package. (#7673)
There are no further uses of this package anywhere in Tendermint.
All the uses in the Cosmos SDK are for types that now work correctly with the
standard encoding/json package.
2022-01-24 08:15:34 -08:00
dependabot[bot]
f6ebd84ee2 build(deps): Bump vuepress-theme-cosmos from 1.0.182 to 1.0.183 in /docs (#7680)
Bumps [vuepress-theme-cosmos](https://github.com/cosmos/vuepress-theme-cosmos) from 1.0.182 to 1.0.183.
- [Release notes](https://github.com/cosmos/vuepress-theme-cosmos/releases)
- [Commits](https://github.com/cosmos/vuepress-theme-cosmos/commits)

---
updated-dependencies:
- dependency-name: vuepress-theme-cosmos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
2022-01-24 05:57:39 -08:00
dependabot[bot]
80d3765ebf build(deps): Bump docker/build-push-action from 2.7.0 to 2.8.0 (#7679)
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2.7.0 to 2.8.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases">docker/build-push-action's releases</a>.</em></p>
<blockquote>
<h2>v2.8.0</h2>
<ul>
<li>Allow specifying subdirectory with default git context (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/531">#531</a>)</li>
<li>Add <code>cgroup-parent</code>, <code>shm-size</code>, <code>ulimit</code> inputs (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/501">#501</a>)</li>
<li>Don't set outputs if empty or nil (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/470">#470</a>)</li>
<li>docs: example to sanitize tags with metadata-action (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/476">#476</a>)</li>
<li>docs: wrong syntax to sanitize repo slug (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/475">#475</a>)</li>
<li>docs: test before pushing your image (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/455">#455</a>)</li>
<li>readme: remove v1 section (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/500">#500</a>)</li>
<li>ci: virtual env file system info (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/510">#510</a>)</li>
<li>dev: update workflow (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/499">#499</a>)</li>
<li>Bump <code>@​actions/core</code> from 1.5.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/160">#160</a>)</li>
<li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/469">#469</a>)</li>
<li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/465">#465</a>)</li>
<li>Bump csv-parse from 4.16.0 to 4.16.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/451">#451</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/459">#459</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1814d3dfb3"><code>1814d3d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/531">#531</a> from BeyondEvil/subdir-with-default-context</li>
<li><a href="fc5a732e0c"><code>fc5a732</code></a> Add subdirectory for Git context</li>
<li><a href="b1aeb1103e"><code>b1aeb11</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/510">#510</a> from crazy-max/venv</li>
<li><a href="e31f93ab9f"><code>e31f93a</code></a> ci: virtual env file system info</li>
<li><a href="9ed5823618"><code>9ed5823</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/501">#501</a> from crazy-max/new-inputs</li>
<li><a href="4222161e3e"><code>4222161</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/500">#500</a> from crazy-max/readme</li>
<li><a href="67ff4df4b7"><code>67ff4df</code></a> add <code>cgroup-parent</code>, <code>shm-size</code>, <code>ulimit</code> inputs</li>
<li><a href="91274a04da"><code>91274a0</code></a> sort flags</li>
<li><a href="ff329397c0"><code>ff32939</code></a> readme: remove v1 section</li>
<li><a href="04841f2a72"><code>04841f2</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/499">#499</a> from crazy-max/update-workflow</li>
<li>Additional commits viewable in <a href="https://github.com/docker/build-push-action/compare/v2.7.0...v2.8.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=docker/build-push-action&package-manager=github_actions&previous-version=2.7.0&new-version=2.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
2022-01-24 10:25:34 +00:00
M. J. Fromberger
f9c6cc9306 rpc: use encoding/json rather than tmjson (#7670)
The main change here is to use encoding/json to encode and decode RPC 
parameters, rather than the custom tmjson package. This includes:

- Update the HTTP POST handler parameter handling.
- Add field tags to 64-bit integer types to get string encoding (to match amino/tmjson).
- Add marshalers to struct types that mention interfaces.
- Inject wrappers to decode interface arguments in RPC handlers.
2022-01-21 15:10:28 -08:00
M. J. Fromberger
72c2e6a5b8 jsontypes: improve tests and error diagnostics (#7669)
Avert panics for corner cases (e.g., nil pointers) and for implementations that
reside only on the pointer type. Add documentation and tests.
2022-01-21 09:51:21 -08:00
Sam Kleinman
8280672d33 mempool: reactor concurrency test tweaks (#7651) 2022-01-21 12:07:58 -05:00
M. J. Fromberger
5a1b5b0229 Update pending changelog from #7607. (#7666) 2022-01-21 08:00:03 -08:00
Alexander Shcherbakov
3f2da0e4e3 Fix query against the latest state in light client (#7642) 2022-01-21 15:24:46 +01:00
William Banfield
db7d4abdae consensus: fix height advances in test state (#7648)
The problem with the `TestStateFullRound1` is that the state that we are observeing, `cs`, can advance to the next height before we query its data. Specifically, on line `388`, when we called `validatePrevote`, the `cs` State had already advanced to height 2, so querying that State for the votes of height 1 either yielded nil or an erroneous value. This change adds a `ensurePrevoteMatch` function that checks that the prevote occurred and checks that it is for the expected block at the same time. If this change looks reasonable I can just apply the same fix to all of the places where we perform `ensurePrevote` followed by `validatePrevote` to use this function instead.
2022-01-20 22:21:41 +00:00
Sam Kleinman
78e4c7d379 autofile: avoid shutdown race (#7650) 2022-01-20 17:06:44 -05:00
Sam Kleinman
9dd67ad99d tests: update cleanup opertunities (#7647) 2022-01-20 15:48:26 -05:00
kmax.eth
449e127e6c privval: avoid re-signing vote when RHS and signbytes are equal (#7592)
* avoid re-signing vote when RHS and signbytes are equal

* avoid re-signing proposal when RHS and signbytes are equal

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
2022-01-20 15:06:13 -05:00
Sam Kleinman
9f4f51318c tests: update docker versions to match build version (#7646) 2022-01-20 12:17:32 -05:00
Jasmina Malicevic
d68d25dcd5 light: return light client status on rpc /status (#7536)
*light: rpc /status returns status of light client ; code refactoring
 light: moved lightClientInfo into light.go, renamed String to ID
test/e2e: Return light client trusted height instead of SyncInfo trusted height
test/e2e/start.go: Not waiting for light client to catch up in tests. Removed querying of syncInfo in start if the node is a light node

* light: Removed call to primary /status. Added trustedPeriod to light info
* light/provider: added ID function to return IP of primary and witnesses
* light/provider/http/http_test: renamed String() to ID()
2022-01-20 14:53:20 +01:00