Callum Waters and GitHub
3ecc0ffe7e
evidence: replace mock evidence with mocked duplicate vote evidence ( #5036 )
2020-06-24 07:24:30 +02:00
65d7ce9c9c
evidence: improve amnesia evidence handling ( #5003 )
...
fix bug so that PotentialAmnesiaEvidence is being gossiped
handle inbound amnesia evidence correctly
add method to check if potential amnesia evidence is on trial
fix a bug with the height when we upgrade to amnesia evidence
change evidence to using just pointers.
More logging in the evidence module
Co-authored-by: Marko <marbar3778@yahoo.com >
2020-06-23 17:09:14 +02:00
Anton Kaliaev and GitHub
44b306b38e
types: reject blocks w/ ConflictingHeadersEvidence ( #5041 )
...
* types: reject blocks w/ ConflictingHeadersEvidence
Closes #5037
* types: reject blocks w/ PotentialAmnesiaEvidence
as well
PotentialAmnesiaEvidence does not contribute anything on its own,
therefore should not be committed on chain.
* fix lint issue
2020-06-23 16:55:16 +04:00
Anton Kaliaev and GitHub
ceac02b891
types: add AppVersion to ConsensusParams ( #5031 )
...
Co-authored-by: JamesRay <66258875@qq.com >
making it possible to change app version via EndBlock
2020-06-23 12:14:16 +04:00
Anton Kaliaev and GitHub
0b13059216
types: fix evidence timestamp calculation ( #5032 )
...
depending on the votes order in DuplicateVoteEvidence is arbitrary.
we should always choose the latest timestamp.
Closes #5030
2020-06-23 07:10:57 +00:00
Marko and GitHub
dedf0d2350
proto: folder structure adhere to buf ( #5025 )
2020-06-22 10:00:51 +02:00
51da4fe356
types: rename partsheader to partsetheader ( #5029 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-22 09:38:03 +02:00
Anton Kaliaev and GitHub
8b4a30fada
types: more test cases for TestValidatorSet_VerifyCommit ( #5018 )
...
Refs #4926
2020-06-19 10:09:41 +00:00
Marko and GitHub
95d2d136cd
types: remove pubkey options ( #5016 )
...
## Description
This PR removes options in picking different pubkey types. We don't support anything other than ed25519 so this was redundant.
We only ever supported ed25519 keys so not sure why we exposed different options.
Not sure if this needs a changelog entry ?
Closes: #XXX
2020-06-17 09:35:00 +00:00
Marko and GitHub
8149bf517f
types: add tests for blockmeta ( #5013 )
...
## Description
add tests for to/from proto for blockmeta and add validate basic test case.
Closes: #XXX
2020-06-16 17:45:15 +00:00
4774a8ec61
non breaking signbytes ( #5008 )
...
* test-vectors for backwards compatibility:
- copy & paste test-vectors from v0.33.5 to ensure
backwards compatibility for vote's SignBytes
* WIP: everything besides time seems to match :-/
* almost
* Found the culprit: field nums weren't consecutive ints ...
* fix order of partset header too
* this last votes-related test can easily be fixed
* some minor changes and fix last failing test
* move proto types back to stdtime, fix various linting
* use libs/protoio
* remvoe commented code
* add comments
* fix tests
* uncomment testscases
* dont ignore error panic
* fix signable test
* fix happy path testing
* fix comment
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com >
2020-06-15 21:54:58 +02:00
Marko and GitHub
74cae49c3b
proto: leftover amino ( #4986 )
2020-06-15 11:14:36 +02:00
Anton Kaliaev and GitHub
a8d8600308
[block#LastResultsHash] add Events + GasWanted/Used ( #4845 )
...
Closes #1007
2020-06-12 12:49:14 +04:00
Marko and GitHub
f6243d8b9e
privval: migrate to protobuf ( #4985 )
2020-06-11 11:54:02 +02:00
Marko and GitHub
31a361d119
proto: move keys to oneof ( #4983 )
2020-06-11 11:10:37 +02:00
Marko and GitHub
46f6d17601
crypto/merkle: remove simple prefix ( #4989 )
...
## Description
This PR removes simple prefix from all types in the crypto/merkle directory.
The two proto types `Proof` & `ProofOp` have been moved to the `proto/crypto/merkle` directory.
proto messge `Proof` was renamed to `ProofOps` and `SimpleProof` message to `Proof`.
Closes : #2755
2020-06-10 14:57:38 +00:00
Callum Waters and GitHub
5697e144a7
evidence: adr56 form amnesia evidence ( #4821 )
...
Creates Amnesia Evidence which is formed from Potential Amnesia Evidence with either a matching proof or after a period of time denoted as the Amnesia Trial Period. This also adds the code necessary so that Amnesia Evidence can be validated and committed on a block
2020-06-10 13:53:55 +02:00
Stevan Ognjanovic and GitHub
89665e7d67
types: Remove duplicated validation in VerifyCommit ( #4991 )
2020-06-09 17:15:32 +02:00
Marko and GitHub
99985278d4
evidence: migrate reactor to proto ( #4949 )
...
## Description
migration of evidence reactor to proto
Closes: #XXX
2020-06-09 07:54:47 +00:00
Marko and GitHub
a89f2581fc
blockchain: proto migration ( #4969 )
...
## Description
migration of blockchain reactors to protobuf
Closes: #XXX
2020-06-08 12:45:03 +00:00
Erik Grinaker and GitHub
db8f1b3df3
migrate all JSON to new JSON encoder ( #4975 )
...
Uses new JSON encoder in #4955 for all JSON. Branched off of #4968 .
2020-06-08 12:22:59 +00:00
Erik Grinaker and GitHub
ba3a2dde37
rpc: replace Amino with new JSON encoder ( #4968 )
...
Migrates the `rpc` package to use new JSON encoder in #4955 . Branched off of that PR.
Tests pass, but I haven't done any manual testing beyond that. This should be handled as part of broader 0.34 testing.
2020-06-08 12:04:05 +00:00
Marko and GitHub
dcc67642fa
proto: remove amino proto tests ( #4982 )
...
## Description
These tests were made to test the compatibility of amino and protobuf. Since we are moving to protobuf they are not needed anymore.
The proto3 directory was created to be used only in these tests
Closes: #XXX
2020-06-08 09:49:47 +00:00
Marko and GitHub
4a87d60736
light: migrate to proto ( #4964 )
2020-06-08 09:14:58 +02:00
Marko and GitHub
f9f4916bc3
store: proto migration ( #4974 )
...
## Description
migrate store to protobuf
Closes: #XXX
2020-06-08 06:43:29 +00:00
Marko and GitHub
9ef266b88f
types: migrate params to protobuf ( #4962 )
2020-06-05 15:29:53 +02:00
Anton Kaliaev and GitHub
245794a3fd
types: remove VerifyFutureCommit ( #4961 )
...
It was previously used by the now removed `lite` package.
2020-06-05 12:31:30 +00:00
Marko and GitHub
b4aca980e9
proto: change to use gogofaster ( #4957 )
2020-06-05 14:18:44 +02:00
Marko and GitHub
b9af87c4ea
state: proto migration ( #4951 )
2020-06-05 10:47:16 +02:00
Marko and GitHub
ee91312d34
proto: add more to/from ( #4956 )
...
## Description
adding in some more to/from methods/functions
Closes: #XXX
2020-06-05 04:42:04 +00:00
Marko and GitHub
dc49dcc1c1
evidence: json tags for DuplicateVoteEvidence ( #4959 )
...
## Description
Add json tags to duplicate evidence
Closes : #4958
2020-06-04 22:41:16 +00:00
Marko and GitHub
a88537bb88
ints: stricter numbers ( #4939 )
2020-06-04 16:34:56 +02:00
Marko and GitHub
7c576f02ab
keys: change to []bytes ( #4950 )
2020-06-04 15:32:42 +02:00
Marko and GitHub
c2578e2262
light: rename lite2 to light & remove lite ( #4946 )
...
This PR removes lite & renames lite2 to light throughout the repo
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com >
Closes : #4944
2020-06-03 10:13:42 +00:00
Marko and GitHub
99d88cbe2f
crypto: remove key suffixes ( #4941 )
...
## Description
- remove keyname suffix from keys
Closes : #2228
2020-06-03 05:46:29 +00:00
Marko and GitHub
0da7d87351
proto: move mempool to proto ( #4940 )
...
* proto: move mempool to proto
- changes according to moving the mempool reactor to proto
Signed-off-by: Marko Baricevic <marbar3778@yahoo.com >
Closes : #2883
2020-06-03 05:30:52 +00:00
Callum Waters and GitHub
8cd3dec102
types: create ValidateBasic() funcs for validator and validator set ( #4905 )
2020-05-28 11:40:39 +02:00
Erik Grinaker and GitHub
f1000794f2
types/test: remove slow test cases in TestValSetUpdatePriorityOrderTests ( #4903 )
...
These test cases are extremely slow when running with the race detector, often taking more that 2 minutes on my local machine. I can easily see them timing out on the much slower CI machines, causing these failures:
```
panic: test timed out after 5m0s
goroutine 234 [running]:
testing.(*M).startAlarm.func1()
/usr/local/go/src/testing/testing.go:1460 +0x11c
created by time.goFunc
/usr/local/go/src/time/sleep.go:168 +0x52
goroutine 1 [chan receive, 4 minutes]:
testing.(*T).Run(0xc000172c60, 0x107a5a2, 0x22, 0x11bfc68, 0x1)
/usr/local/go/src/testing/testing.go:1044 +0x699
testing.runTests.func1(0xc000172c60)
/usr/local/go/src/testing/testing.go:1285 +0xa7
testing.tRunner(0xc000172c60, 0xc00012bcc8)
/usr/local/go/src/testing/testing.go:992 +0x1ec
testing.runTests(0xc00000e2c0, 0x1901500, 0x72, 0x72, 0x0)
/usr/local/go/src/testing/testing.go:1283 +0x528
testing.(*M).Run(0xc000214380, 0x0)
/usr/local/go/src/testing/testing.go:1200 +0x300
github.com/tendermint/tendermint/types.TestMain(0xc000214380)
/go/src/github.com/tendermint/tendermint/types/block_test.go:30 +0x59
main.main()
_testmain.go:380 +0x334
goroutine 255 [runnable]:
bytes.Equal(...)
/usr/local/go/src/bytes/bytes.go:20
github.com/tendermint/tendermint/types.(*ValidatorSet).GetByAddress(0xc005499020, 0xc006056650, 0x5, 0x8, 0x13af, 0xc005514100)
/go/src/github.com/tendermint/tendermint/types/validator_set.go:253 +0xfd
github.com/tendermint/tendermint/types.verifyUpdates.func1(0xc00614b940, 0xc005499020, 0x47cd)
/go/src/github.com/tendermint/tendermint/types/validator_set.go:415 +0x84
github.com/tendermint/tendermint/types.verifyUpdates(0xc006110000, 0x11b7, 0x1780, 0xc005499020, 0xb52ff, 0x0, 0x0, 0x5c9)
/go/src/github.com/tendermint/tendermint/types/validator_set.go:429 +0x220
github.com/tendermint/tendermint/types.(*ValidatorSet).updateWithChangeSet(0xc005499020, 0xc00602c000, 0x1780, 0x1780, 0xc006098201, 0xc00608d4b8, 0xc006037bf8)
/go/src/github.com/tendermint/tendermint/types/validator_set.go:600 +0x2f3
github.com/tendermint/tendermint/types.(*ValidatorSet).UpdateWithChangeSet(0xc005499020, 0xc00602c000, 0x1780, 0x1780, 0x1780, 0x1780)
/go/src/github.com/tendermint/tendermint/types/validator_set.go:636 +0x78
github.com/tendermint/tendermint/types.applyChangesToValSet(0xc0005c8ea0, 0x0, 0x0, 0xc005499020, 0xc0005d1160, 0x3, 0x3)
/go/src/github.com/tendermint/tendermint/types/validator_set_test.go:1169 +0x1bb
github.com/tendermint/tendermint/types.verifyValSetUpdatePriorityOrder(0xc0005c8ea0, 0xc005499020, 0x0, 0x0, 0xc005600000, 0x2710, 0x2710, 0xc0055c8000, 0x5c9, 0x5c9, ...)
/go/src/github.com/tendermint/tendermint/types/validator_set_test.go:1239 +0x217
github.com/tendermint/tendermint/types.TestValSetUpdatePriorityOrderTests(0xc0005c8ea0)
/go/src/github.com/tendermint/tendermint/types/validator_set_test.go:1228 +0x1205
testing.tRunner(0xc0005c8ea0, 0x11bfc68)
/usr/local/go/src/testing/testing.go:992 +0x1ec
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:1043 +0x661
FAIL github.com/tendermint/tendermint/types 300.677s
FAIL
```
2020-05-27 11:10:49 +00:00
Callum Waters and GitHub
2014357a19
evidence: remove header from phantom evidence ( #4892 )
2020-05-27 09:20:45 +02:00
Anton Kaliaev and GitHub
187120a04d
types: remove unnecessary sort call ( #4876 )
...
in TestValSetUpdatePriorityOrderTests https://app.circleci.com/pipelines/github/tendermint/tendermint/3849/workflows/6d241fc8-72a8-4a3b-b3fc-887a48518f82/jobs/114996
also, reduce the number of reactors in TestReactorBroadcastTxMessage https://app.circleci.com/pipelines/github/tendermint/tendermint/3797/workflows/935cda34-dfb3-46e9-8257-92277171c91b/jobs/114562
2020-05-26 13:16:58 +00:00
Marko and GitHub
e03b61abd2
proto: add proto files for ibc unblock ( #4853 )
...
## Description
these proto files are meant to help unblock ibc in their quest of migrating the ibc module to proto.
Closes: #XXX
2020-05-25 15:52:34 +00:00
Callum Waters and GitHub
c0682a3bed
evidence: prevent proposer from proposing duplicate pieces of evidence ( #4839 )
...
prevent proposer from proposing duplicate pieces of evidence
2020-05-13 18:46:30 +02:00
Anton Kaliaev and GitHub
84b9bde9cd
types: assert specific error in TestValSetUpdateOverflowRelated
...
Closes #4183
2020-05-12 17:56:02 +00:00
Anton Kaliaev and GitHub
b7b721c484
change use of errors.Wrap to fmt.Errorf with %w verb
...
Closes #4603
Commands used (VIM):
```
:args `rg -l errors.Wrap`
:argdo normal @q | update
```
where q is a macros rewriting the `errors.Wrap` to `fmt.Errorf`.
2020-05-12 03:35:47 +00:00
Marko and GitHub
8d63d7192f
abci: regenerate proto files
...
## Description
regenerate proto stubs
I do find max_num to be vague. possibly renaming to max_entries or max_evidence_entries may be more descriptive?
Closes: #XXX
2020-05-11 16:54:54 +00:00
Callum Waters and GitHub
7cb3d90e01
evidence: create proof of lock change and implement it in evidence store ( #4746 )
...
creates a proof of lock change which is an array of votes that proves the validator was permitted to change locked block and vote again. This proof is stored in the evidence pool and is used as a part of amnesia evidence
2020-05-11 17:06:01 +02:00
Callum Waters and GitHub
a620e5fd96
evidence: cap evidence to an absolute number ( #4780 )
...
The number of evidence that can be committed in a single block is capped by a new evidence parameter called MaxNum
2020-05-11 15:28:08 +02:00
Anton Kaliaev and GitHub
826a7150b7
types: remove extra validation in VerifyCommit
...
plus make sure LastCommit is always non-nil
2020-05-07 09:49:51 +00:00
Anton Kaliaev and GitHub
d202fab478
types: simplify VerifyCommitTrusting
...
Closes #4783
It looks like we're validating Commit twice. Also, height and blockID params were coming from the commit, so no need to pass them separately.
2020-05-07 09:24:31 +00:00
Anton Kaliaev and GitHub
8b2ed8933a
consensus: fix TestSimulateValidatorsChange
...
* consensus: fix TestSimulateValidatorsChange
* fix selfIndex calculation
* exit from goroutine after 1 sec
* reuse the function
2020-05-07 09:14:21 +00:00
Callum WatersandGitHub
Anton KaliaevandGitHub
Stevan OgnjanovicandGitHub
Erik GrinakerandGitHub