Thane Thomson
f618fc2a1c
Make extendedCommitInfo function more robust
...
At first extendedCommitInfo expected votes to be in the same order as
their corresponding validators in the supplied CommitInfo struct, but
this proved to be rather difficult since when a validator set's loaded
from state it's first sorted by voting power and then by address.
Instead of sorting the votes in the same way, this approach simply maps
votes to their corresponding validator's address prior to constructing
the extended commit info. This way it's easy to look up the
corresponding vote and we don't need to care about vote order.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-29 08:35:13 -04:00
Thane Thomson
620c3236ec
Add strong guarantee in extendedCommitInfo that the number of votes corresponds
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-28 11:45:06 -04:00
Thane Thomson
fab3cd0932
Add strong correctness guarantees when constructing extended commit info for ABCI++
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-28 11:41:24 -04:00
Thane Thomson
01b6a4f2d5
Panic on ABCI++ method call failure
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-28 11:40:36 -04:00
Thane Thomson
cbe85608cb
Rewrite loop for clarity
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-25 10:37:06 -04:00
Thane Thomson
617f47fe44
Use dummy value with clearer meaning
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-25 10:36:59 -04:00
Thane Thomson
806e348af8
Update internal/consensus/common_test.go
...
Co-authored-by: Sergio Mena <sergio@informal.systems >
2022-03-25 10:36:45 -04:00
Thane Thomson
9951b7ad81
Sync intermediate and goal protos
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-24 08:04:39 -04:00
Thane Thomson
f3188e543c
Fix ABCI proto generation scripts for Linux
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-24 08:04:07 -04:00
Thane Thomson
040cb566fb
Merge latest changes from master and resolve conflicts
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-24 08:03:42 -04:00
William Banfield
e4ae922c33
consensus: update state machine to use the new consensus params ( #8181 )
2022-03-23 11:26:42 -04:00
Sam Kleinman
cbce877480
consensus: add leaktest check to replay tests ( #8185 )
2022-03-23 00:00:08 +00:00
Sam Kleinman
b29cc95920
consensus: cleanup tempfile explictly ( #8184 )
2022-03-22 17:41:00 -04:00
Sam Kleinman
0c9558a742
consensus: avoid panic during shutdown ( #8170 )
2022-03-22 15:28:33 -04:00
William Banfield
e2fc50ec9f
types: add TimeoutParams into ConsensusParams structs ( #8177 )
2022-03-22 11:19:54 -04:00
William Banfield
2361e0c65c
abci++: remove CheckTx call from PrepareProposal flow ( #8176 )
2022-03-22 10:03:35 -04:00
dependabot[bot]
e2365c1368
build(deps): Bump github.com/golangci/golangci-lint from 1.44.2 to 1.45.0 ( #8169 )
...
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint ) from 1.44.2 to 1.45.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/releases ">github.com/golangci/golangci-lint's releases</a>.</em></p>
<blockquote>
<h2>v1.45.0</h2>
<h2>Changelog</h2>
<ul>
<li>ea1df6f1 Default to YAML when config file has no extension (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2618 ">#2618</a>)</li>
<li>93a0015c build(deps): bump actions/checkout from 2 to 3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2643 ">#2643</a>)</li>
<li>176ef3f7 build(deps): bump actions/setup-node from 2 to 3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2628 ">#2628</a>)</li>
<li>adc0d8ec build(deps): bump github.com/ashanbrown/makezero from 1.1.0 to 1.1.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2621 ">#2621</a>)</li>
<li>8f9bc4a7 build(deps): bump github.com/daixiang0/gci from 0.3.1 to 0.3.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2640 ">#2640</a>)</li>
<li>6fc688ae build(deps): bump github.com/securego/gosec/v2 from 2.9.6 to 2.10.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2624 ">#2624</a>)</li>
<li>da08d2bd build(deps): bump github.com/shirou/gopsutil/v3 from 3.22.1 to 3.22.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2641 ">#2641</a>)</li>
<li>873a27e7 build(deps): bump github.com/sivchari/containedctx from 1.0.1 to 1.0.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2623 ">#2623</a>)</li>
<li>ec952367 build(deps): bump github.com/spf13/cobra from 1.3.0 to 1.4.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2646 ">#2646</a>)</li>
<li>0e7233eb build(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.4.0 to 2.5.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2603 ">#2603</a>)</li>
<li>0bcc0a3b build(deps): bump golangci/golangci-lint-action from 2.5.2 to 3.1.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2627 ">#2627</a>)</li>
<li>5ffadacb build(deps): bump mvdan.cc/gofumpt from 0.2.1 to 0.3.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2622 ">#2622</a>)</li>
<li>d5ebd7eb build(deps): bump node-fetch in /.github/contributors (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2616 ">#2616</a>)</li>
<li>5ddb5e7a bump github.com/daixiang0/gci to v0.3.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2596 ">#2596</a>)</li>
<li>56d77e2b bump github.com/denis-tingaikin/go-header from 0.4.2 to 0.4.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2614 ">#2614</a>)</li>
<li>2f689958 errcheck: add an option to remove default exclusions (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2607 ">#2607</a>)</li>
<li>1f4c1ed9 fix: completion for fish-shell</li>
<li>0c0804c6 go1.18 support (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2438 ">#2438</a>)</li>
<li>42ca6449 gofumpt: add module-path setting (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2644 ">#2644</a>)</li>
<li>30c6166b revive: fix default values (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2611 ">#2611</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md ">github.com/golangci/golangci-lint's changelog</a>.</em></p>
<blockquote>
<h3>v1.45.0</h3>
<ol>
<li>updated linters:
<ul>
<li><code>cobra</code>: from 1.3.0 to 1.4.0</li>
<li><code>containedctx</code>: from 1.0.1 to 1.0.2</li>
<li><code>errcheck</code>: add an option to remove default exclusions</li>
<li><code>gci</code>: from 0.3.1 to 0.3.2</li>
<li><code>go-header</code>: from 0.4.2 to 0.4.3</li>
<li><code>gofumpt</code>: add module-path setting</li>
<li><code>gofumpt</code>: from 0.2.1 to 0.3.0</li>
<li><code>gopsutil</code>: from 3.22.1 to 3.22.2</li>
<li><code>gosec</code>: from 2.9.6 to 2.10.0</li>
<li><code>makezero</code>: from 1.1.0 to 1.1.1</li>
<li><code>revive</code>: fix default values</li>
<li><code>wrapcheck</code>: from 2.4.0 to 2.5.0</li>
</ul>
</li>
<li>documentation:
<ul>
<li>docs: add "back to the top" button</li>
<li>docs: add <code>forbidigo</code> example that uses comments</li>
<li>docs: improve linters page</li>
</ul>
</li>
<li>misc:
<ul>
<li>go1.18 support 🎉 </li>
<li>Add an option to manage the targeted version of Go</li>
<li>Default to YAML when config file has no extension</li>
</ul>
</li>
</ol>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1f4c1ed9f9 "><code>1f4c1ed</code></a> fix: completion for fish-shell</li>
<li><a href="0c0804c6a4 "><code>0c0804c</code></a> go1.18 support (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2438 ">#2438</a>)</li>
<li><a href="ec952367e9 "><code>ec95236</code></a> build(deps): bump github.com/spf13/cobra from 1.3.0 to 1.4.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2646 ">#2646</a>)</li>
<li><a href="42ca644953 "><code>42ca644</code></a> gofumpt: add module-path setting (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2644 ">#2644</a>)</li>
<li><a href="93a0015cfc "><code>93a0015</code></a> build(deps): bump actions/checkout from 2 to 3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2643 ">#2643</a>)</li>
<li><a href="d7b28ca346 "><code>d7b28ca</code></a> build(deps): bump normalize-url from 4.5.0 to 4.5.1 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2642 ">#2642</a>)</li>
<li><a href="da08d2bd2a "><code>da08d2b</code></a> build(deps): bump github.com/shirou/gopsutil/v3 from 3.22.1 to 3.22.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2641 ">#2641</a>)</li>
<li><a href="8f9bc4a794 "><code>8f9bc4a</code></a> build(deps): bump github.com/daixiang0/gci from 0.3.1 to 0.3.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2640 ">#2640</a>)</li>
<li><a href="41646f256f "><code>41646f2</code></a> build(deps): bump gatsby-plugin-manifest from 4.7.0 to 4.9.0 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2635 ">#2635</a>)</li>
<li><a href="fdd7218ead "><code>fdd7218</code></a> build(deps): bump <code>@emotion/react</code> from 11.7.1 to 11.8.1 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2634 ">#2634</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint/compare/v1.44.2...v1.45.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-03-21 22:31:49 +00:00
Sam Kleinman
43943d2dce
rollback: cleanup second node during test ( #8175 )
2022-03-21 16:13:43 -04:00
William Banfield
cc838a5a19
ABCI++: Update new protos to use enum instead of bool ( #8158 )
...
closes : #8039
This pull request updates the new ABCI++ protos to use `enum`s in place of `bool`s. `enums` may be preferred over `bool` because an `enum` can be udpated to include new statuses in the future, whereas a `bool` cannot and is fixed as just `true` or `false` over the whole lifecycle of the API.
2022-03-21 16:57:34 +00:00
Sam Kleinman
c33be0a410
state: propogate error from state store ( #8171 )
...
* state: propogate error from state store
* fix lint
2022-03-21 15:28:42 +00:00
Sam Kleinman
c680cca96e
consensus: reduce size of test fixtures and logging rate ( #8172 )
...
We can reduce the size of test fixtures (which will improve test
reliability) without impacting these tests' primary role (which is
correctness.)
Also reducing these test logging will make the tests easier to read,
which whill be a good quality of life improvement for devs.
2022-03-21 15:07:52 +00:00
dependabot[bot]
039fef14e0
build(deps): Bump docker/build-push-action from 2.9.0 to 2.10.0 ( #8167 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2.9.0 to 2.10.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases ">docker/build-push-action's releases</a>.</em></p>
<blockquote>
<h2>v2.10.0</h2>
<ul>
<li>Add <code>imageid</code> output and use metadata to set <code>digest</code> output (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/569 ">#569</a>)</li>
<li>Add <code>build-contexts</code> input (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/563 ">#563</a>)</li>
<li>Enhance outputs display (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/559 ">#559</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="ac9327eae2 "><code>ac9327e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/563 ">#563</a> from crazy-max/new-inputs</li>
<li><a href="7c41daf2a5 "><code>7c41daf</code></a> <code>build-contexts</code> input</li>
<li><a href="e115266953 "><code>e115266</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/569 ">#569</a> from crazy-max/imageid-digest</li>
<li><a href="50fa0058d9 "><code>50fa005</code></a> add imageid output and use metadata to set digest output</li>
<li><a href="309fb9180f "><code>309fb91</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/568 ">#568</a> from docker/dependabot/github_actions/actions/checkout-3</li>
<li><a href="db68526220 "><code>db68526</code></a> Bump actions/checkout from 2 to 3</li>
<li><a href="fe02965b48 "><code>fe02965</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/559 ">#559</a> from crazy-max/outputs</li>
<li><a href="5af8693d82 "><code>5af8693</code></a> Enhance outputs display</li>
<li>See full diff in <a href="https://github.com/docker/build-push-action/compare/v2.9.0...v2.10.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-03-21 13:56:13 +00:00
dependabot[bot]
3a75fbceec
build(deps): Bump gaurav-nelson/github-action-markdown-link-check from 1.0.13 to 1.0.14 ( #8166 )
...
Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check ) from 1.0.13 to 1.0.14.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gaurav-nelson/github-action-markdown-link-check/releases ">gaurav-nelson/github-action-markdown-link-check's releases</a>.</em></p>
<blockquote>
<h2>1.0.14</h2>
<h2>Changes</h2>
<ul>
<li><a href="https://github-redirect.dependabot.com/gaurav-nelson/github-action-markdown-link-check/pull/116 ">gaurav-nelson/github-action-markdown-link-check#116</a> - Changed the base image to more stage Node image <code>node:lts-alpine</code></li>
<li><a href="https://github-redirect.dependabot.com/gaurav-nelson/github-action-markdown-link-check/pull/126 ">gaurav-nelson/github-action-markdown-link-check#126</a> - Use markdown-link-check version 3.9.3</li>
</ul>
<p>Thank you <a href="https://github.com/thanethomson "><code>@thanethomson</code></a> <a href="https://github.com/edumco "><code>@edumco</code></a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="58f84fd654 "><code>58f84fd</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/gaurav-nelson/github-action-markdown-link-check/issues/116 ">#116</a> from edumco/docker-update</li>
<li><a href="56618d65ea "><code>56618d6</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/gaurav-nelson/github-action-markdown-link-check/issues/126 ">#126</a> from thanethomson/bump-mlc-version</li>
<li><a href="611438d456 "><code>611438d</code></a> Bump markdown-link-check version to 3.9.3</li>
<li><a href="8f0156cc69 "><code>8f0156c</code></a> Update Ko-fi link</li>
<li><a href="af2ced5c1b "><code>af2ced5</code></a> Changes base image to LTS</li>
<li><a href="9de9db77de "><code>9de9db7</code></a> Fixed broken link</li>
<li>See full diff in <a href="https://github.com/gaurav-nelson/github-action-markdown-link-check/compare/1.0.13...1.0.14 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-03-21 12:42:01 +00:00
Thane Thomson
dfe82436a5
Format
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-21 08:35:39 -04:00
Thane Thomson
0527731920
Update types/vote_test.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-03-21 08:31:18 -04:00
Thane Thomson
4b626169f9
Update privval/file.go
...
Co-authored-by: M. J. Fromberger <fromberger@interchain.io >
2022-03-21 08:26:58 -04:00
Thane Thomson
65f1902c4c
Remove extraneous comment
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 14:26:40 -04:00
Thane Thomson
e0ca4549de
Explicitly ensure length > 0 to sign vote extension
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 14:25:03 -04:00
Thane Thomson
25a7312e35
Explicitly ensure length > 0 to sign vote extension
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 14:22:30 -04:00
Thane Thomson
ab50582319
Fix missing VerifyVoteExtension request data
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 14:12:05 -04:00
Thane Thomson
9431db98e3
Fix lint
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:38:53 -04:00
Thane Thomson
19e07c9a8c
Remove extraneous empty value initialization
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:34:46 -04:00
Thane Thomson
71d36953c3
Thread vote extensions through code and fix tests
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:34:46 -04:00
Thane Thomson
aac3df4901
Inject vote extensions into proposal
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:34:46 -04:00
Thane Thomson
306d56870a
Regenerate protos including latest PBTS synchrony params update
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:34:46 -04:00
Thane Thomson
c978c29515
Move CanonicalVoteExtension to canonical types proto defs
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:34:45 -04:00
Thane Thomson
da4fedc382
Fix types tests
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:34:45 -04:00
Thane Thomson
ce54bf3bdb
Better describe method given vote extensions
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:34:45 -04:00
Thane Thomson
116bbf091f
Fix typo
...
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:34:44 -04:00
Thane Thomson
8fbe537d5d
Refactor so building and linting works
...
This is the first step towards implementing vote extensions: generating
the relevant proto stubs and getting the build and linter to pass.
Signed-off-by: Thane Thomson <connect@thanethomson.com >
2022-03-20 13:34:44 -04:00
M. J. Fromberger
ea964e2133
node: always sync with the application at startup ( #8159 )
2022-03-19 21:18:17 -07:00
William Banfield
485c96b0d3
consensus: change lock handling in reactor and handleMsg for RoundState (forward-port #7994 #7992 ) ( #8139 )
...
Related to #8157
2022-03-18 18:59:44 +00:00
Sam Kleinman
9a833a8495
consensus: skip channel close during shutdown ( #8155 )
...
I see this panic in tests occasionally, and I don't think there's any
need to close this channel:
- it's only sent to in one place which has a select case with a
default clause, so there's no chance of deadlocks.
- the only place we recieve from it thas a timeout.
2022-03-18 18:35:42 +00:00
Sam Kleinman
0bded371c5
testing: logger cleanup ( #8153 )
...
This contains two major changes:
- Remove the legacy test logging method, and just explicitly call the
noop logger. This is just to make the test logging behavior more
coherent and clear.
- Move the logging in the light package from the testing.T logger to
the noop logger. It's really the case that we very rarely need/want
to consider test logs unless we're doing reproductions and running a
narrow set of tests.
In most cases, I (for one) prefer to run in verbose mode so I can
watch progress of tests, but I basically never need to consider
logs. If I do want to see logs, then I can edit in the testing.T
logger locally (which is what you have to do today, anyway.)
2022-03-18 17:39:38 +00:00
Sam Kleinman
12d13cd31d
mempool: reduce size of test ( #8152 )
...
This is failing intermittently, but it's a really simple test, and I
suspect that we're just running into thread scheduling issues on CI
nodes. I don't think making the test smaller reduces the utility of
this test.
2022-03-18 16:55:10 +00:00
William Banfield
bba8367aac
state: panic on ResponsePrepareProposal validation error ( #8145 )
...
* state: panic on ResponsePrepareProposal validation error
* lint++
Co-authored-by: Sam Kleinman <garen@tychoish.com >
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-03-18 16:42:29 +00:00
Sam Kleinman
f1a8f47d4d
types: minor cleanup of un or minimally used types ( #8154 )
2022-03-18 16:27:10 +00:00
Sam Kleinman
f61e6e4201
autofile: remove vestigal close mechanism ( #8150 )
2022-03-18 12:05:53 -04:00
Sam Kleinman
1db41663c7
consensus: avoid race in accessing channel ( #8149 )
2022-03-18 09:54:40 -04:00
Sam Kleinman
5e0e05f938
consensus: avoid persistent kvstore in tests ( #8148 )
2022-03-18 09:39:06 -04:00