Kaizhe Huang and GitHub 0f54eefe6f
e2e-test-kind.yaml / extract (push) Failing after 9s
Run the E2E test on kind / get-go-version (push) Failing after 10s
Run the E2E test on kind / build (push) Skipped
Run the E2E test on kind / setup-test-matrix (push) Failing after 3s
Run the E2E test on kind / run-e2e-test (push) Skipped
push.yml / extract (push) Failing after 6s
Main CI / get-go-version (push) Failing after 6s
Main CI / Build (push) Skipped
Scorecard supply-chain security / Scorecard analysis (push) Skipped
Fix unchecked type assertion panic in ChangeImageNameAction ( #10574 ) ...
* Fix unchecked type assertion panic in ChangeImageNameAction
replaceImageName reads a restored container's image field out of the
unstructured object and asserts it to string without checking ok. The
comma-ok map lookup on the line above only confirms the "image" key is
present -- it says nothing about the value's type. A restored resource
whose image field is present but not a JSON string (e.g. a number,
bool, null, array, or object) causes an unrecovered
"interface conversion: interface {} is not string" panic in this
RestoreItemAction plugin whenever the optional image-remapping
ConfigMap feature is configured.
Switch to the comma-ok form of the assertion and skip (with a log
message) any container whose image field isn't a string, instead of
panicking.
Signed-off-by: Kaizhe Huang <derek0405@gmail.com >
* Add regression test for non-string image field panic
Covers the comma-ok assertion fix: replaceImageName operates on
generic unstructured content decoded from a backup tarball, which
isn't validated against the Pod schema before this code runs, so
"image" isn't guaranteed to be a string.
Signed-off-by: Kaizhe Huang <derek0405@gmail.com >
* Guard container-entry type assertion, use unstructured.NestedString
Addresses reviewer feedback: container.(map[string]any) was also an
unchecked assertion, and unstructured.NestedString gives safer,
more idiomatic type-checking than a manual comma-ok assertion. Also
switches the skip-path logging from Info to Warn per review.
Signed-off-by: Kaizhe Huang <derek0405@gmail.com >
---------
Signed-off-by: Kaizhe Huang <derek0405@gmail.com >
2026-09-28 15:29:50 +08:00
2026-09-17 15:31:29 +08:00
2026-04-01 14:27:18 -04:00
2026-02-11 12:43:55 -05:00
2026-02-09 01:03:45 -05:00
2026-04-08 12:08:56 -07:00
2026-02-24 23:17:03 +08:00
2026-02-19 14:28:15 -05:00
2026-04-13 14:52:42 -04:00
2026-04-07 10:22:38 -07:00
2026-02-13 17:42:46 +08:00
2026-03-04 15:11:01 +00:00
2026-05-06 16:30:36 +08:00
2026-04-13 14:52:42 -04:00
2026-04-13 14:52:42 -04:00
2026-03-02 10:49:14 +11:00
2026-03-05 14:22:53 +08:00
2026-09-14 18:05:01 -04:00
2026-03-10 13:40:09 -04:00
2026-04-23 00:20:05 -04:00
2026-03-13 16:42:10 +08:00
2026-03-19 02:38:11 +05:30
2026-04-13 14:52:42 -04:00
2026-03-24 04:05:20 -04:00
2026-03-24 20:49:16 +05:30
2026-09-22 20:06:46 -04:00
2026-04-07 09:12:51 +05:00
2026-04-22 16:10:46 +02:00
2026-04-13 14:52:42 -04:00
2026-04-03 13:23:57 +08:00
2026-04-13 14:52:42 -04:00
2026-04-13 14:52:42 -04:00
2026-04-08 16:50:09 +08:00
2026-04-14 15:07:49 +08:00
2026-04-22 13:24:22 -07:00
2026-04-14 16:36:40 -04:00
2026-04-08 15:47:06 -07:00
2026-08-05 11:48:39 -07:00
2026-04-14 18:26:49 -04:00
2026-04-13 13:42:30 +08:00
2026-04-10 15:53:46 +08:00
2026-04-16 02:56:25 -04:00
2026-04-17 15:38:44 +08:00
2026-08-05 08:17:44 -07:00
2026-04-16 18:02:30 +08:00
2026-04-15 23:46:31 +08:00
2026-04-22 14:07:54 +08:00
2026-04-21 14:14:24 +08:00
2026-04-28 03:11:49 -04:00
2026-08-26 14:46:04 +08:00
2026-05-21 22:05:40 -04:00
2026-06-08 16:10:32 -04:00
2026-08-24 10:27:34 -04:00
2026-05-22 12:26:00 +08:00
2026-05-22 06:26:40 +00:00
2026-05-21 14:22:36 +08:00
2026-05-22 14:32:37 +08:00
2026-05-21 15:36:51 +08:00
2026-05-23 12:39:10 +08:00
2026-05-22 07:46:23 +00:00
2026-05-26 08:57:56 +08:00
2026-05-27 14:59:16 +08:00
2026-06-04 13:24:27 +08:00
2026-05-25 11:08:40 +08:00
2026-05-28 14:30:11 +08:00
2026-05-28 14:41:54 +08:00
2026-05-28 16:13:09 +08:00
2026-07-01 15:19:52 +08:00
2026-06-01 14:43:43 +08:00
2026-06-04 12:20:59 -04:00
2026-06-03 13:23:08 +08:00
2026-06-08 15:50:05 +08:00
2026-06-04 13:25:16 +08:00
2026-06-05 17:02:41 +08:00
2026-06-09 18:08:59 +08:00
2026-06-09 10:23:22 -07:00
2026-06-10 10:00:30 +08:00
2026-06-17 08:30:33 -04:00
2026-06-17 08:29:01 -04:00
2026-06-15 16:08:38 +08:00
2026-06-15 16:18:54 +08:00
2026-06-16 17:47:21 +08:00
2026-08-18 10:28:27 -07:00
2026-06-15 12:20:13 -07:00
2026-06-25 11:31:08 +08:00
2026-06-18 15:39:44 +08:00
2026-06-22 16:22:33 +08:00
2026-06-22 17:35:44 +08:00
2026-06-25 15:29:18 +08:00
2026-06-25 11:06:53 +08:00
2026-06-24 11:09:23 -07:00
2026-06-24 17:37:36 -07:00
2026-06-25 08:31:32 +00:00
2026-06-25 17:09:57 +08:00
2026-08-25 18:42:30 +00:00
2026-07-15 08:35:06 +00:00
2026-07-01 11:56:48 -04:00
2026-07-09 22:56:56 -04:00
2026-07-20 15:55:54 -04:00
2026-07-09 17:41:55 +08:00
2026-07-08 17:40:43 +08:00
2026-07-08 11:39:06 -07:00
2026-07-09 13:15:59 +08:00
2026-07-10 13:00:43 -04:00
2026-09-03 14:36:51 -04:00
2026-08-03 23:28:01 -07:00
2026-07-11 10:09:39 +08:00
2026-07-13 14:51:54 -07:00
2026-07-16 13:44:41 +08:00
2026-07-14 12:22:52 -04:00
2026-07-22 09:17:59 -07:00
2026-07-15 15:26:23 +08:00
2026-07-15 15:24:17 +08:00
2026-07-15 17:29:20 +08:00
2026-07-17 11:42:09 -07:00
2026-07-17 16:35:19 +08:00
2026-08-03 16:36:55 +08:00
2026-07-20 09:18:13 -04:00
2026-07-18 17:14:43 +03:30
2026-07-29 15:55:51 +08:00
2026-08-10 15:36:14 -04:00
2026-07-22 13:41:46 +08:00
2026-07-24 16:03:51 -04:00
2026-07-27 15:36:44 +08:00
2026-07-24 14:55:43 -07:00
2026-07-24 14:02:19 +08:00
2026-07-27 16:36:55 -04:00
2026-07-28 14:04:15 +08:00
2026-07-28 13:20:34 +08:00
2026-07-30 12:24:51 -04:00
2026-08-03 13:19:48 -07:00
2026-07-31 06:02:43 +00:00
2026-08-04 06:25:05 +00:00
2026-07-31 15:02:23 +08:00
2026-07-31 16:24:17 +08:00
2026-08-25 15:23:55 -04:00
2026-09-15 09:50:10 -04:00
2026-08-04 14:49:08 +05:30
2026-08-04 13:48:57 +08:00
2026-08-13 16:52:23 +08:00
2026-08-09 11:01:32 -05:00
2026-08-09 10:15:29 -05:00
2026-08-12 15:12:58 +08:00
2026-08-06 10:52:03 +05:30
2026-08-12 10:24:40 -07:00
2026-08-11 16:52:21 +08:00
2026-08-18 13:08:41 +08:00
2026-08-30 21:40:25 -04:00
2026-08-11 16:58:19 +00:00
2026-08-12 15:42:53 +08:00
2026-08-11 17:04:26 +08:00
2026-08-11 15:42:48 -04:00
2026-08-11 14:07:59 +08:00
2026-08-11 15:48:31 +08:00
2026-08-17 16:55:29 +08:00
2026-08-11 11:44:02 -04:00
2026-08-11 14:33:02 -04:00
2026-08-14 16:18:00 +08:00
2026-08-12 13:53:56 +08:00
2026-08-14 15:37:05 +08:00
2026-08-14 16:17:29 +08:00
2026-08-13 12:21:20 -04:00
2026-08-12 22:49:21 +08:00
2026-08-21 17:26:21 +08:00
2026-08-17 14:59:27 +08:00
2026-08-17 16:55:01 +08:00
2026-08-14 15:30:45 +08:00
2026-08-17 16:29:01 +08:00
2026-08-14 16:17:16 +08:00
2026-08-17 16:29:42 +08:00
2026-08-14 13:49:21 +08:00
2026-08-17 16:19:55 +08:00
2026-09-18 23:04:55 -04:00
2026-08-17 13:37:44 +08:00
2026-08-21 15:15:30 -04:00
2026-08-17 13:39:03 +08:00
2026-08-17 16:55:14 +08:00
2026-08-17 16:05:21 +08:00
2026-08-27 12:57:20 -04:00
2026-08-19 15:03:33 +08:00
2026-08-25 18:08:17 -04:00
2026-08-18 00:25:36 -04:00
2026-08-20 23:40:59 +08:00
2026-08-18 03:40:05 +05:30
2026-09-09 06:34:06 +00:00
2026-08-18 16:09:32 +08:00
2026-08-24 14:17:25 -04:00
2026-08-19 17:32:50 +08:00
2026-08-21 17:41:30 +08:00
2026-08-25 08:32:47 -07:00
2026-08-20 14:15:56 -04:00
2026-08-20 10:37:41 +08:00
2026-08-24 09:21:06 +00:00
2026-08-21 11:19:57 +08:00
2026-09-17 14:16:39 -04:00
2026-08-21 15:11:09 -04:00
2026-08-27 13:45:51 +08:00
2026-08-24 16:13:53 +08:00
2026-08-24 13:45:41 +08:00
2026-08-27 13:54:48 +08:00
2026-08-26 17:57:36 +08:00
2026-08-24 15:32:56 -04:00
2026-08-24 11:24:04 -07:00
2026-08-24 14:08:29 +05:30
2026-08-25 18:27:40 +00:00
2026-08-27 05:43:05 +05:30
2026-09-01 17:08:25 +08:00
2026-09-01 15:43:53 +08:00
2026-08-28 12:50:50 +08:00
2026-09-07 14:48:41 +08:00
2026-08-29 12:15:11 +05:30
2026-08-30 11:14:19 +05:30
2026-09-01 06:46:48 +05:30
2026-09-02 12:03:06 -04:00
2026-09-16 15:16:29 +08:00
2026-09-02 15:38:36 +08:00
2026-09-03 13:59:42 +08:00
2026-09-04 11:16:42 +08:00
2026-09-04 16:10:54 +08:00
2026-09-09 16:52:11 -04:00
2026-09-16 17:00:29 -04:00
2026-09-09 10:24:42 -04:00
2026-09-08 18:15:34 +08:00
2026-09-09 14:04:57 +08:00
2026-09-09 17:34:17 +08:00
2026-09-15 11:14:29 +03:00
2026-09-11 17:10:14 +08:00
2026-09-10 15:04:54 +08:00
2026-09-10 18:22:35 +08:00
2026-09-10 18:39:04 +05:30
2026-09-16 20:34:20 +08:00
2026-09-11 00:34:13 -04:00
2026-09-11 14:21:41 -07:00
2026-09-18 16:51:00 +08:00
2026-09-12 11:41:04 +03:00
2026-09-16 16:55:27 -04:00
2026-09-15 17:38:30 +08:00
2026-09-21 05:29:26 +00:00
2026-09-17 11:13:18 +08:00
2026-09-21 10:54:59 +08:00
2026-09-19 17:34:06 -05:00
2026-09-22 11:53:35 +08:00
2026-09-23 13:28:06 +08:00
2026-09-21 07:37:08 -07:00
2026-09-28 15:29:00 +08:00
2026-09-24 15:02:47 +08:00
2026-09-24 16:26:11 -04:00
2026-09-28 15:29:50 +08:00
2026-09-28 11:18:50 +08:00
2026-09-24 16:57:39 +08:00
2026-09-24 16:21:52 -07:00
2026-09-25 23:34:04 +05:30
Kaizhe HuangandGitHub
0f54eefe6f