scst_debug(): Avoid that debug_print_with_prefix() overflows the output buffer

Detected by Coverity.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
This commit is contained in:
Bart Van Assche
2015-04-29 15:43:02 +02:00
parent 0da80bb241
commit dff213dc8e

View File

@@ -75,11 +75,11 @@ int debug_print_with_prefix(unsigned long trace_flag, const char *severity,
spin_lock_irqsave(&trace_buf_lock, flags);
strcpy(trace_buf, severity);
strlcpy(trace_buf, severity, TRACE_BUF_SIZE);
i = strlen(trace_buf);
if (trace_flag & TRACE_PID)
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE, "[%d]: ", pid);
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "[%d]: ", pid);
if (prefix != NULL)
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "%s: ",
prefix);